Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2347963002: [DevTools] Show distribution for Shadow DOM V1. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
hayato, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, pfeldman+blink_chromium.org, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Show distribution for Shadow DOM V1. We show shortcuts to distributed nodes as children of slot elements. BUG=647767 Committed: https://crrev.com/e11af1f748a4236062fffa6b7db7dc5f79d20c7e Cr-Commit-Position: refs/heads/master@{#419648}

Patch Set 1 #

Patch Set 2 : getDistributedNodes -> iteration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -47 lines) Patch
M third_party/WebKit/LayoutTests/inspector/elements/shadow/create-shadow-root.html View 2 chunks +36 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/create-shadow-root-expected.txt View 3 chunks +34 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/inspect-deep-shadow-element.html View 2 chunks +24 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/inspect-deep-shadow-element-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/shadow-distribution.html View 1 chunk +170 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/shadow-distribution-expected.txt View 1 chunk +257 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/shadow-root.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/shadow-root-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 4 chunks +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
dgozman
Hi, Could you please take a look? There is a screenshot in the bug. Thanks, ...
4 years, 3 months ago (2016-09-16 21:32:27 UTC) #2
pfeldman
awesome! lgtm
4 years, 3 months ago (2016-09-16 21:55:12 UTC) #3
hayato
lgtm
4 years, 3 months ago (2016-09-17 22:57:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347963002/1
4 years, 3 months ago (2016-09-18 07:05:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/298353)
4 years, 3 months ago (2016-09-18 08:33:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347963002/20001
4 years, 3 months ago (2016-09-19 23:32:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 02:06:15 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 02:09:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e11af1f748a4236062fffa6b7db7dc5f79d20c7e
Cr-Commit-Position: refs/heads/master@{#419648}

Powered by Google App Engine
This is Rietveld 408576698