Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2347953002: format GN files, and invert if->config to config->if (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

format GN files, and invert if->config to config->if Both if (...) { config ... } else { config ... } and config { if (...) { ...} else { ... } } work. We just happen to do the if inside the config more often than the other way around. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347953002 Committed: https://skia.googlesource.com/skia/+/b9be979eaecebcb5350efae46e6555188e7c3a78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -126 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M gn/BUILD.gn View 8 chunks +128 lines, -125 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-16 20:45:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347953002/1
4 years, 3 months ago (2016-09-16 20:45:12 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-16 20:45:15 UTC) #6
herb_g
lgtm
4 years, 3 months ago (2016-09-16 20:56:48 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 21:44:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b9be979eaecebcb5350efae46e6555188e7c3a78

Powered by Google App Engine
This is Rietveld 408576698