Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2347943002: Update bots so they use iOS10 SDK (Closed)

Created:
4 years, 3 months ago by sczs1
Modified:
4 years, 3 months ago
Reviewers:
sczs, smut
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update bots so they use iOS10 SDK Xcode 8 should be installed upstream already, so in order to land changes than use iOS10 SDK we need to update the bots. BUG=none Committed: https://crrev.com/3a408779b41f7a2306c3f6c3015ef31447159428 Cr-Commit-Position: refs/heads/master@{#419324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M ios/build/bots/chromium.mac/ios-device.json View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-device-gn.json View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator.json View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator-cronet.json View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator-gn.json View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator-swarming.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sczs
Hi Sana, Could you please take a look at these bot config changes.
4 years, 3 months ago (2016-09-16 20:34:01 UTC) #5
smut
Thank you for doing this. I'm going to trigger a few try jobs first, since ...
4 years, 3 months ago (2016-09-16 21:27:44 UTC) #6
sczs
On 2016/09/16 21:27:44, smut wrote: > Thank you for doing this. I'm going to trigger ...
4 years, 3 months ago (2016-09-16 22:19:39 UTC) #7
smut
lgtm
4 years, 3 months ago (2016-09-16 22:43:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347943002/1
4 years, 3 months ago (2016-09-16 22:43:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 23:33:34 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 23:35:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a408779b41f7a2306c3f6c3015ef31447159428
Cr-Commit-Position: refs/heads/master@{#419324}

Powered by Google App Engine
This is Rietveld 408576698