Introduce Promise mapping to the IDL generator

Source/bindings/v8/ScriptPromise.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef AnimatableUnknown_h
-#define AnimatableUnknown_h
+#ifndef ScriptPromise_h
+#define ScriptPromise_h
 
-#include "core/animation/AnimatableValue.h"
+#include "bindings/v8/ScopedPersistent.h"
+#include "bindings/v8/ScriptValue.h"
+#include "bindings/v8/V8ScriptRunner.h"
+#include <v8.h>
 
 namespace WebCore {
 
-class AnimatableUnknown : public AnimatableValue {
+// ScriptPromise is the class for representing Promise values in C++ world.
+// ScriptPromise holds a Promise.
+// So holding ScriptPromise as a member variable causes memory leaks
+// since it has a reference from C++ to V8.
+//

[yusukesuzuki, 2013/09/04 06:37:00]

Added the comment about possible memory leaks.

[yhirano, 2013/09/04 07:13:17]

"So holding a ScriptPromise as a member variable in a DOM object causes..." is
better, I think.

[yusukesuzuki, 2013/09/04 08:02:07]

Done. Thanks!

+class ScriptPromise {
 public:
-    virtual ~AnimatableUnknown() { }
-
-    static PassRefPtr<AnimatableUnknown> create(PassRefPtr<CSSValue> value)
+    ScriptPromise()
+        : m_promise()
     {
-        return adoptRef(new AnimatableUnknown(value));
     }
 
-    PassRefPtr<CSSValue> toCSSValue() const { return m_value; }
-
-protected:
-    virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue* value, double fraction) const OVERRIDE
+    explicit ScriptPromise(ScriptValue promise)
+        : m_promise(promise)
     {
-        return defaultInterpolateTo(this, value, fraction);
+        ASSERT(!m_promise.hasNoValue());
     }
 
-    virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue* value) const OVERRIDE
+    explicit ScriptPromise(v8::Handle<v8::Value> promise)
+        : m_promise(promise)
     {
-        return defaultAddWith(this, value);
+        ASSERT(!m_promise.hasNoValue());
+    }
+
+    bool isObject() const
+    {
+        return m_promise.isObject();
+    }
+
+    bool isNull() const
+    {
+        return m_promise.isNull();
+    }
+
+    bool isUndefinedOrNull() const
+    {
+        return m_promise.isUndefined() || m_promise.isNull();
+    }
+
+    v8::Handle<v8::Value> v8Value() const
+    {
+        return m_promise.v8Value();
+    }
+
+    void clear()
+    {
+        m_promise.clear();
     }
 
 private:
-    explicit AnimatableUnknown(PassRefPtr<CSSValue> value)
-        : AnimatableValue(TypeUnknown)
-        , m_value(value)
-    {
-        ASSERT(m_value);
-    }
-
-    const RefPtr<CSSValue> m_value;
+    ScriptValue m_promise;
 };
 
-inline const AnimatableUnknown* toAnimatableUnknown(const AnimatableValue* value)
-{
-    ASSERT_WITH_SECURITY_IMPLICATION(value && value->isUnknown());
-    return static_cast<const AnimatableUnknown*>(value);
-}
-
 } // namespace WebCore
 
-#endif // AnimatableUnknown_h
+
+#endif // ScriptPromise_h