Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 23479015: thread isolate in PreallocatedStorageAllocationPolicy (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

thread isolate in PreallocatedStorageAllocationPolicy R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16467

Patch Set 1 #

Patch Set 2 : forgot explicit dtor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M src/allocation.h View 2 chunks +15 lines, -2 lines 0 comments Download
M src/allocation-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/list.h View 1 4 chunks +14 lines, -5 lines 0 comments Download
M src/string-stream.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/zone.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-list.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-02 10:04:03 UTC) #1
Sven Panne
LGTM. I'm not totally happy with our template magic for policies, but this has been ...
7 years, 3 months ago (2013-09-02 10:57:55 UTC) #2
dcarney
7 years, 3 months ago (2013-09-02 11:20:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16467 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698