Issue 23479010: Add length checks to ApiMessageWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23479010: Add length checks to ApiMessageWriter. (Closed)

Created:
7 years, 3 months ago by Michael Lippautz (Google)

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add length checks to ApiMessageWriter. Addresses issue 4314. BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27298

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -31 lines)			Patch
M	runtime/bin/dartutils.h	View	1 2	5 chunks	+14 lines, -12 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 2	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/include/dart_native_api.h	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	1 2	9 chunks	+48 lines, -11 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	2 chunks	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Lippautz (Google)

Omitted tests checking fails for strings and bigints, as they would require actual payload in ...

7 years, 3 months ago (2013-08-30 21:02:52 UTC) #1

siva

Adding Søren to the reviewer list. The change LGTM but please wait for an LGTM ...

7 years, 3 months ago (2013-09-04 00:03:57 UTC) #3

Michael Lippautz (Google)

Committed patchset #2 manually as r27298 (presubmit successful).

7 years, 3 months ago (2013-09-09 16:50:45 UTC) #4

Michael Lippautz (Google)

7 years, 3 months ago (2013-09-09 16:51:01 UTC) #5

Message was sent while issue was closed.

On 2013/09/09 16:50:45, Michael Lippautz wrote:
> Committed patchset #2 manually as r27298 (presubmit successful).

Committed as discussed offline with Siva.

Expand Messages | Collapse Messages