Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2347893002: Revert of CertVerifyProcMac: Add Keychain re-ordering hack, check CRLsets in path pruning loop. (Closed)

Created:
4 years, 3 months ago by davidben
Modified:
4 years, 3 months ago
Reviewers:
cbentzel, Ryan Sleevi, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CertVerifyProcMac: Add Keychain re-ordering hack, check CRLsets in path pruning loop. (patchset #11 id:300001 of https://codereview.chromium.org/2101303005/ ) Reason for revert: This breaks verification on OS X 10.12 and probably needs some further investigation. Original issue's description: > CertVerifyProcMac: Add Keychain re-ordering hack, check CRLsets in path pruning loop. > > This also removes the native hostname checking workarounds. > > BUG=570909, 588789, 621684 > > Committed: https://crrev.com/9cedf75377d817c6b32a01f1d30fbe10663b8bb8 > Cr-Commit-Position: refs/heads/master@{#418732} TBR=rsleevi@chromium.org,mattm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=570909, 588789, 621684, 647241 Committed: https://crrev.com/03a7397bd4ed8c059a7f5977a7672769fb783626 Cr-Commit-Position: refs/heads/master@{#419245}

Patch Set 1 #

Patch Set 2 : git cl patch is broken so try a manual revert instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -881 lines) Patch
M net/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M net/cert/cert_verify_proc_mac.cc View 1 8 chunks +73 lines, -166 lines 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 1 2 chunks +0 lines, -155 lines 0 comments Download
D net/cert/test_keychain_search_list_mac.h View 1 chunk +0 lines, -46 lines 0 comments Download
D net/cert/test_keychain_search_list_mac.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M net/data/ssl/certificates/README View 1 2 chunks +0 lines, -13 lines 0 comments Download
D net/data/ssl/certificates/multi-root-BFE.keychain View Binary file 0 comments Download
D net/data/ssl/certificates/tripadvisor-verisign-chain.pem View 1 chunk +0 lines, -221 lines 0 comments Download
D net/data/ssl/certificates/verisign_class3_g5_crosssigned.pem View 1 chunk +0 lines, -92 lines 0 comments Download
D net/data/ssl/certificates/verisign_class3_g5_crosssigned-trusted.keychain View Binary file 0 comments Download
D net/data/ssl/scripts/generate-keychain.sh View 1 chunk +0 lines, -73 lines 0 comments Download
D net/data/ssl/scripts/generate-multi-root-BFE-keychain.sh View 1 chunk +0 lines, -18 lines 0 comments Download
D net/data/ssl/scripts/generate-verisign_class3_g5_crosssigned-trusted-keychain.sh View 1 chunk +0 lines, -19 lines 0 comments Download
M net/net.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 6 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
davidben
Created Revert of CertVerifyProcMac: Add Keychain re-ordering hack, check CRLsets in path pruning loop.
4 years, 3 months ago (2016-09-16 15:21:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347893002/1
4 years, 3 months ago (2016-09-16 15:22:45 UTC) #4
cbentzel
On 2016/09/16 15:22:45, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 3 months ago (2016-09-16 15:35:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/297740)
4 years, 3 months ago (2016-09-16 16:30:33 UTC) #7
davidben
On 2016/09/16 16:30:33, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-16 16:40:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347893002/250001
4 years, 3 months ago (2016-09-16 18:22:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:250001)
4 years, 3 months ago (2016-09-16 19:21:38 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:23:14 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03a7397bd4ed8c059a7f5977a7672769fb783626
Cr-Commit-Position: refs/heads/master@{#419245}

Powered by Google App Engine
This is Rietveld 408576698