Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2347883002: Remove legacy API on Utf16CharacterStream. (Closed)

Created:
4 years, 3 months ago by vogelheim
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove legacy API on Utf16CharacterStream. BUG=v8:4947 Committed: https://crrev.com/b36c60cce85c08efca5b288a4dfb10a0831aafe3 Cr-Commit-Position: refs/heads/master@{#39533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -66 lines) Patch
M src/parsing/parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parsing/scanner.h View 7 chunks +9 lines, -40 lines 0 comments Download
M src/parsing/scanner.cc View 5 chunks +13 lines, -19 lines 0 comments Download
M test/cctest/parsing/test-scanner-streams.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
vogelheim
ptal
4 years, 3 months ago (2016-09-16 15:04:35 UTC) #6
marja
lgtm
4 years, 3 months ago (2016-09-19 07:44:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347883002/1
4 years, 3 months ago (2016-09-20 09:19:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 09:43:44 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b36c60cce85c08efca5b288a4dfb10a0831aafe3 Cr-Commit-Position: refs/heads/master@{#39533}
4 years, 3 months ago (2016-09-20 09:44:06 UTC) #12
Toon Verwaest
4 years, 3 months ago (2016-09-20 22:47:45 UTC) #14
Message was sent while issue was closed.
Doesn't this explicitly disallow lazy parsing of nested functions, which is what
Marja is trying to support? (Since bookmarks cannot be nested as it's just being
kept track of by the scanner directly rather than the BookmarkScope.)

Powered by Google App Engine
This is Rietveld 408576698