Add proper lifetime of encoder-specific settings

webrtc/media/engine/fakewebrtccall.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 168 matching lines @@
 }
 
 webrtc::VideoSendStream::Stats FakeVideoSendStream::GetStats() {
   return stats_;
 }
 
 void FakeVideoSendStream::ReconfigureVideoEncoder(
     webrtc::VideoEncoderConfig config) {
   if (config.encoder_specific_settings != NULL) {
     if (config_.encoder_settings.payload_name == "VP8") {
-      vpx_settings_.vp8 = *reinterpret_cast<const webrtc::VideoCodecVP8*>(
-                              config.encoder_specific_settings);
+      config.encoder_specific_settings->FillVideoCodecVp8(&vpx_settings_.vp8);
       if (!config.streams.empty()) {
         vpx_settings_.vp8.numberOfTemporalLayers = static_cast<unsigned char>(
             config.streams.back().temporal_layer_thresholds_bps.size() + 1);
       }
     } else if (config_.encoder_settings.payload_name == "VP9") {
-      vpx_settings_.vp9 = *reinterpret_cast<const webrtc::VideoCodecVP9*>(
-                              config.encoder_specific_settings);
+      config.encoder_specific_settings->FillVideoCodecVp9(&vpx_settings_.vp9);
       if (!config.streams.empty()) {
         vpx_settings_.vp9.numberOfTemporalLayers = static_cast<unsigned char>(
             config.streams.back().temporal_layer_thresholds_bps.size() + 1);
       }
     } else {
       ADD_FAILURE() << "Unsupported encoder payload: "
                     << config_.encoder_settings.payload_name;
     }
   }
+  codec_settings_set_ = config.encoder_specific_settings != NULL;
   encoder_config_ = std::move(config);
-  codec_settings_set_ = config.encoder_specific_settings != NULL;
   ++num_encoder_reconfigurations_;
 }
 
 void FakeVideoSendStream::Start() {
   sending_ = true;
 }
 
 void FakeVideoSendStream::Stop() {
   sending_ = false;
 }
@@ skipping 272 matching lines @@
 }
 
 bool FakeCall::StartEventLog(rtc::PlatformFile log_file,
                              int64_t max_size_bytes) {
   return false;
 }
 
 void FakeCall::StopEventLog() {}
 
 }  // namespace cricket