Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: src/transitions.h

Issue 234783002: Handlify Map::CopyDropDescriptors(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Some more refactoring. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | src/transitions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/transitions.h
diff --git a/src/transitions.h b/src/transitions.h
index f23523e2365e9d74438accc36684fe1803f2832f..0c1acf8633b33182211040130cf05cf51902562a 100644
--- a/src/transitions.h
+++ b/src/transitions.h
@@ -95,13 +95,8 @@ class TransitionArray: public FixedArray {
inline int number_of_entries() { return number_of_transitions(); }
- // Allocate a new transition array with a single entry.
- static Handle<TransitionArray> NewWith(Handle<Map> map,
- Handle<Name> name,
- Handle<Map> target,
- SimpleTransitionFlag flag);
-
- MUST_USE_RESULT MaybeObject* ExtendToFullTransitionArray();
+ static Handle<TransitionArray> ExtendToFullTransitionArray(
+ Handle<TransitionArray> array);
// Create a transition array, copying from the owning map if it already has
// one, otherwise creating a new one according to flag.
@@ -112,21 +107,13 @@ class TransitionArray: public FixedArray {
Handle<Map> target,
SimpleTransitionFlag flag);
- // Copy a single transition from the origin array.
- inline void NoIncrementalWriteBarrierCopyFrom(TransitionArray* origin,
- int origin_transition,
- int target_transition);
-
// Search a transition for a given property name.
inline int Search(Name* name);
// Allocates a TransitionArray.
- MUST_USE_RESULT static MaybeObject* Allocate(
+ static Handle<TransitionArray> Allocate(
Isolate* isolate, int number_of_transitions);
- MUST_USE_RESULT static MaybeObject* AllocateSimple(
- Isolate* isolate, Map* target);
-
bool IsSimpleTransition() {
return length() == kSimpleTransitionSize &&
get(kSimpleTransitionTarget)->IsHeapObject() &&
@@ -204,10 +191,24 @@ class TransitionArray: public FixedArray {
kTransitionTarget;
}
+ static Handle<TransitionArray> AllocateSimple(
+ Isolate* isolate, Handle<Map> target);
+
+ // Allocate a new transition array with a single entry.
+ static Handle<TransitionArray> NewWith(Handle<Map> map,
+ Handle<Name> name,
+ Handle<Map> target,
+ SimpleTransitionFlag flag);
+
inline void NoIncrementalWriteBarrierSet(int transition_number,
Name* key,
Map* target);
+ // Copy a single transition from the origin array.
+ inline void NoIncrementalWriteBarrierCopyFrom(TransitionArray* origin,
+ int origin_transition,
+ int target_transition);
+
DISALLOW_IMPLICIT_CONSTRUCTORS(TransitionArray);
};
« no previous file with comments | « src/objects-inl.h ('k') | src/transitions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698