Handlify Map::CopyDropDescriptors().

Handlify Map::CopyDropDescriptors().

* And contain knowledge better in TransitionArray and DescriptorArray (for example WhitenessWitness is now private to DescriptorArray).
* And remove some factory methods
* And handlify some other things.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20686

[mvstanton, 2014-04-11 10:28:20]

Hi Toon, handlification along with reduced usage of the WhitenessWitness. 
--Michael

[Toon Verwaest, 2014-04-11 10:34:32]

https://codereview.chromium.org/234783002/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/234783002/diff/40001/src/bootstrapper.cc#newc...
src/bootstrapper.cc:398: map->set_instance_descriptors(*descriptors);
What about Map::EnsureDescriptorSlack(map, size);
(same below).

[Toon Verwaest, 2014-04-11 10:37:59]

https://codereview.chromium.org/234783002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/234783002/diff/40001/src/objects.cc#newcode15629
src/objects.cc:15629: ASSERT_LE(unused_property_fields, inobject_props);
DisallowHeapAllocation no_gc; while committing the state.

https://codereview.chromium.org/234783002/diff/40001/src/objects.cc#newcode15707
src/objects.cc:15707: 
DisallowHeapAllocation no_gc while committing state.

https://codereview.chromium.org/234783002/diff/40001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/234783002/diff/40001/src/objects.h#newcode3549
src/objects.h:3549: inline explicit WhitenessWitness(FixedArray* array);
DescriptorArray* descriptors?

[mvstanton, 2014-04-11 11:25:20]

Hi Toon, thx for comments.
I also
1) removed TransitionArray and Descriptors from the factory
2) Handlified a few additional methods for TransitionArray.
--Michael

https://codereview.chromium.org/234783002/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/234783002/diff/40001/src/bootstrapper.cc#newc...
src/bootstrapper.cc:398: map->set_instance_descriptors(*descriptors);
On 2014/04/11 10:34:32, Toon Verwaest wrote:
> What about Map::EnsureDescriptorSlack(map, size);
> (same below).

Done.

https://codereview.chromium.org/234783002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/234783002/diff/40001/src/objects.cc#newcode15707
src/objects.cc:15707: 
On 2014/04/11 10:37:59, Toon Verwaest wrote:
> DisallowHeapAllocation no_gc while committing state.

Done.

https://codereview.chromium.org/234783002/diff/40001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/234783002/diff/40001/src/objects.h#newcode3549
src/objects.h:3549: inline explicit WhitenessWitness(FixedArray* array);
On 2014/04/11 10:37:59, Toon Verwaest wrote:
> DescriptorArray* descriptors?

Sure.

[Toon Verwaest, 2014-04-11 12:01:34]

lgtm, thanks ;)

[mvstanton, 2014-04-11 12:14:03]

Committed patchset #5 manually as r20686 (presubmit successful).