|
|
Chromium Code Reviews
DescriptionAdding target to build SwiftShader
Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium.
BUG=630728
Patch Set 1 #Patch Set 2 : Trying out the _REENTRANT flag #Patch Set 3 : Enabling compilation, only for Windows #Messages
Total messages: 16 (10 generated)
Description was changed from ========== Test to compile SwiftShader on different platforms BUG= ========== to ========== Adding target to build SwiftShader Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728 ==========
sugoi@chromium.org changed reviewers: + thakis@chromium.org
3rd attempt. It seems landing this for Windows and Linux simultaneously was a bit ambitious. The Linux issue doesn't seem very trivial at this point, so let's try Windows only first to see if there are more issues left that the original one (I don't think we got Windows failures last time, but maybe we reverted before more appeared). Let's try to land this and watch the bots...
The CQ bit was checked by sugoi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, good luck Please warn sheriffs and be on IRC
The CQ bit was checked by sugoi@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Adding target to build SwiftShader Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728 ========== to ========== Adding target to build SwiftShader Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Adding target to build SwiftShader Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728 ========== to ========== Adding target to build SwiftShader Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728 Committed: https://crrev.com/abe918907ad9cb56a09000919fc1ed5fda90fb8d Cr-Commit-Position: refs/heads/master@{#419731} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/abe918907ad9cb56a09000919fc1ed5fda90fb8d Cr-Commit-Position: refs/heads/master@{#419731}
Message was sent while issue was closed.
Description was changed from ========== Adding target to build SwiftShader Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728 Committed: https://crrev.com/abe918907ad9cb56a09000919fc1ed5fda90fb8d Cr-Commit-Position: refs/heads/master@{#419731} ========== to ========== Adding target to build SwiftShader Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728 ==========
Message was sent while issue was closed.
I don't know how you picked bots, but don't just run "all of them". This one ran on win_upload_clang, a bot responsible for building new clang binaries and uploading them. Using it on regular chromium CLs doesn't make sense. |
