Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2347823003: Adding SwiftShader compilation on Windows (Closed)

Created:
4 years, 3 months ago by sugoi1
Modified:
4 years, 2 months ago
Reviewers:
Nico, sugoi
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding target to build SwiftShader Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728

Patch Set 1 #

Patch Set 2 : Trying out the _REENTRANT flag #

Patch Set 3 : Enabling compilation, only for Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
sugoi1
3rd attempt. It seems landing this for Windows and Linux simultaneously was a bit ambitious. ...
4 years, 3 months ago (2016-09-19 20:26:18 UTC) #3
Nico
lgtm, good luck Please warn sheriffs and be on IRC
4 years, 3 months ago (2016-09-19 22:48:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347823003/40001
4 years, 3 months ago (2016-09-20 12:49:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-20 12:54:13 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/abe918907ad9cb56a09000919fc1ed5fda90fb8d Cr-Commit-Position: refs/heads/master@{#419731}
4 years, 3 months ago (2016-09-20 12:55:33 UTC) #14
Nico
4 years, 2 months ago (2016-09-21 16:54:42 UTC) #16
Message was sent while issue was closed.
I don't know how you picked bots, but don't just run "all of them". This one ran
on win_upload_clang, a bot responsible for building new clang binaries and
uploading them. Using it on regular chromium CLs doesn't make sense.

Powered by Google App Engine
This is Rietveld 408576698