tracing/tracing/value/ui/scalar_context_controller.html - Issue 2347813002: [tracing] Heap dump UI overhaul

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/value/ui/scalar_context_controller.html

Issue 2347813002: [tracing] Heap dump UI overhaul (Closed)

Patch Set: Improve focus retention and add tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/value/ui/scalar_context_controller.html

diff --git a/tracing/tracing/value/ui/scalar_context_controller.html b/tracing/tracing/value/ui/scalar_context_controller.html

index d56102058526efcb6fb4455b12dcbbcab774ca9b..f99a4558be2cc77f03fbb7121b8091592856c187 100644

--- a/tracing/tracing/value/ui/scalar_context_controller.html

+++ b/tracing/tracing/value/ui/scalar_context_controller.html

@@ -141,8 +141,10 @@ tr.exportTo('tr.v.ui', function() {

_markGroupDirtyAndScheduleUpdate: function(group) {

var alreadyDirty = this.dirtyGroups_.size > 0;

this.dirtyGroups_.add(group);

- if (!alreadyDirty)

- tr.b.requestAnimationFrame(this.updateContext.bind(this));

+ if (!alreadyDirty) {

+ tr.b.requestAnimationFrameInThisFrameIfPossible(

+ this.updateContext, this);

+ }

updateContext: function() {

« no previous file with comments | « tracing/tracing/ui/analysis/memory_dump_heap_details_util.html ('k') | no next file » | no next file with comments »