Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 23478031: Improve code generation for the HRandom instruction. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Improve code generation for the HRandom instruction. Since the per-context random number generator is now properly seeded upon context creation, we do not need to check for lazy-initialization anymore, and so we can implement the HRandom instruction w/o having to call into the C function (which means we don't need to MarkAsCall anymore). TEST=cctest/test-random R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16684

Patch Set 1 #

Total comments: 2

Patch Set 2 : REBASE #

Patch Set 3 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -195 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +12 lines, -3 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +37 lines, -53 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +39 lines, -58 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +12 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +37 lines, -63 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +11 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Hey Yang, This is the improved HRandom implementation we were talking about offline. PTAL. -- ...
7 years, 3 months ago (2013-09-12 09:36:14 UTC) #1
Yang
lgtm. https://codereview.chromium.org/23478031/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/23478031/diff/1/src/arm/lithium-codegen-arm.cc#newcode3916 src/arm/lithium-codegen-arm.cc:3916: // r1: state[0]. these comments are obsolete now.
7 years, 3 months ago (2013-09-12 11:48:22 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/23478031/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/23478031/diff/1/src/arm/lithium-codegen-arm.cc#newcode3916 src/arm/lithium-codegen-arm.cc:3916: // r1: state[0]. On 2013/09/12 11:48:22, Yang wrote: > ...
7 years, 3 months ago (2013-09-12 12:11:50 UTC) #3
Benedikt Meurer
7 years, 3 months ago (2013-09-12 12:12:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r16684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698