Drop empty [] for dictionaries and interfaces in IDL files

Drop and disalllow empty extended attribute lists [] in IDL

WebIDL does not allow this:
https://heycam.github.io/webidl/#prod-ExtendedAttributeList

This was discovered by markdittmer@ when testing webidl2.js.

The changes were made by running this Python script on all IDL files:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the Python script wouldn't miss a case due to trailing
whitespace.

(The cases with comments inside were fixed manually.)

R=rbyers@chromium.org,markdittmer@chromium.org

Committed: https://crrev.com/ff816f196be69a11e903c01262ecba8949d7f2aa
Cr-Commit-Position: refs/heads/master@{#419148}

[foolip, 2016-09-16 08:53:37]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[foolip, 2016-09-16 08:53:38]

Description was changed from

==========
Drop empty [] for dictionaries and interfaces in IDL files

These are the interfaces where webidl2.js complained in markdittmer@'s
testing, plus ones found by a simple Python script:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the python script wouldn't miss a case due to trailing
whitespace.

R=rbyers@chromium.org,markdittmer@chromium.org
==========

to

==========
Drop empty [] for dictionaries and interfaces in IDL files

These are the interfaces where webidl2.js complained in markdittmer@'s
testing, plus ones found by a simple Python script:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the python script wouldn't miss a case due to trailing
whitespace.

R=rbyers@chromium.org,markdittmer@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-16 08:53:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-09-16 09:00:21]

LGTM, but can we also update the IDL parser not to allow an empty []?

[commit-bot: I haz the power, 2016-09-16 11:06:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 11:06:19]

Dry run: This issue passed the CQ dry run.

[foolip, 2016-09-16 11:06:53]

On 2016/09/16 09:00:21, haraken wrote:
> LGTM, but can we also update the IDL parser not to allow an empty []?

Sure, do you know off-hand where that's handled?

[foolip, 2016-09-16 11:10:28]

On 2016/09/16 11:06:53, foolip wrote:
> On 2016/09/16 09:00:21, haraken wrote:
> > LGTM, but can we also update the IDL parser not to allow an empty []?
> 
> Sure, do you know off-hand where that's handled?

Maybe p_ExtendedAttributeList in blink_idl_parser.py, will try that.

[foolip, 2016-09-16 11:31:04]

Description was changed from

==========
Drop empty [] for dictionaries and interfaces in IDL files

These are the interfaces where webidl2.js complained in markdittmer@'s
testing, plus ones found by a simple Python script:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the python script wouldn't miss a case due to trailing
whitespace.

R=rbyers@chromium.org,markdittmer@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Drop and disalllow empty extended attribute lists [] in IDL

WebIDL does not allow this:
https://heycam.github.io/webidl/#prod-ExtendedAttributeList

This was discovered by markdittmer@ when testing webidl2.js.

The changes were made by running this Python script on all IDL files:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the python script wouldn't miss a case due to trailing
whitespace.

(The cases with comments inside were fixed manually.)

R=rbyers@chromium.org,markdittmer@chromium.org
==========

[foolip, 2016-09-16 11:31:43]

Description was changed from

==========
Drop and disalllow empty extended attribute lists [] in IDL

WebIDL does not allow this:
https://heycam.github.io/webidl/#prod-ExtendedAttributeList

This was discovered by markdittmer@ when testing webidl2.js.

The changes were made by running this Python script on all IDL files:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the python script wouldn't miss a case due to trailing
whitespace.

(The cases with comments inside were fixed manually.)

R=rbyers@chromium.org,markdittmer@chromium.org
==========

to

==========
Drop and disalllow empty extended attribute lists [] in IDL

WebIDL does not allow this:
https://heycam.github.io/webidl/#prod-ExtendedAttributeList

This was discovered by markdittmer@ when testing webidl2.js.

The changes were made by running this Python script on all IDL files:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the Python script wouldn't miss a case due to trailing
whitespace.

(The cases with comments inside were fixed manually.)

R=rbyers@chromium.org,markdittmer@chromium.org
==========

[foolip, 2016-09-16 11:31:57]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 11:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-09-16 11:32:41]

On 2016/09/16 11:10:28, foolip wrote:
> On 2016/09/16 11:06:53, foolip wrote:
> > On 2016/09/16 09:00:21, haraken wrote:
> > > LGTM, but can we also update the IDL parser not to allow an empty []?
> > 
> > Sure, do you know off-hand where that's handled?
> 
> Maybe p_ExtendedAttributeList in blink_idl_parser.py, will try that.

That turned out to be very easy, and I've confirmed that it will fail if empty
[] are added back to interfaces or attributes. Can you sanity check and CQ if
good?

[haraken, 2016-09-16 11:38:16]

On 2016/09/16 11:32:41, foolip wrote:
> On 2016/09/16 11:10:28, foolip wrote:
> > On 2016/09/16 11:06:53, foolip wrote:
> > > On 2016/09/16 09:00:21, haraken wrote:
> > > > LGTM, but can we also update the IDL parser not to allow an empty []?
> > > 
> > > Sure, do you know off-hand where that's handled?
> > 
> > Maybe p_ExtendedAttributeList in blink_idl_parser.py, will try that.
> 
> That turned out to be very easy, and I've confirmed that it will fail if empty
> [] are added back to interfaces or attributes. Can you sanity check and CQ if
> good?

LGTM

I think the older version of the Web IDL spec had allowed an empty [], which is
why we had had that line in idl_parser.py :)

[foolip, 2016-09-16 12:14:08]

The CQ bit was unchecked by foolip@chromium.org

[foolip, 2016-09-16 12:14:09]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-09-16 12:14:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 12:38:12]

Description was changed from

==========
Drop and disalllow empty extended attribute lists [] in IDL

WebIDL does not allow this:
https://heycam.github.io/webidl/#prod-ExtendedAttributeList

This was discovered by markdittmer@ when testing webidl2.js.

The changes were made by running this Python script on all IDL files:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the Python script wouldn't miss a case due to trailing
whitespace.

(The cases with comments inside were fixed manually.)

R=rbyers@chromium.org,markdittmer@chromium.org
==========

to

==========
Drop and disalllow empty extended attribute lists [] in IDL

WebIDL does not allow this:
https://heycam.github.io/webidl/#prod-ExtendedAttributeList

This was discovered by markdittmer@ when testing webidl2.js.

The changes were made by running this Python script on all IDL files:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the Python script wouldn't miss a case due to trailing
whitespace.

(The cases with comments inside were fixed manually.)

R=rbyers@chromium.org,markdittmer@chromium.org
==========

[commit-bot: I haz the power, 2016-09-16 12:38:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 12:39:57]

Description was changed from

==========
Drop and disalllow empty extended attribute lists [] in IDL

WebIDL does not allow this:
https://heycam.github.io/webidl/#prod-ExtendedAttributeList

This was discovered by markdittmer@ when testing webidl2.js.

The changes were made by running this Python script on all IDL files:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the Python script wouldn't miss a case due to trailing
whitespace.

(The cases with comments inside were fixed manually.)

R=rbyers@chromium.org,markdittmer@chromium.org
==========

to

==========
Drop and disalllow empty extended attribute lists [] in IDL

WebIDL does not allow this:
https://heycam.github.io/webidl/#prod-ExtendedAttributeList

This was discovered by markdittmer@ when testing webidl2.js.

The changes were made by running this Python script on all IDL files:

with open(sys.argv[1], 'r+') as f:
    text = f.read().replace('[\n] ', '')
    f.seek(0)
    f.write(text)
    f.truncate()

This also runs all IDL files through git stripspace, as a first step to
ensure that the Python script wouldn't miss a case due to trailing
whitespace.

(The cases with comments inside were fixed manually.)

R=rbyers@chromium.org,markdittmer@chromium.org

Committed: https://crrev.com/ff816f196be69a11e903c01262ecba8949d7f2aa
Cr-Commit-Position: refs/heads/master@{#419148}
==========

[commit-bot: I haz the power, 2016-09-16 12:40:00]

Patchset 2 (id:??) landed as
https://crrev.com/ff816f196be69a11e903c01262ecba8949d7f2aa
Cr-Commit-Position: refs/heads/master@{#419148}