Apply several phases only to entrypoint files (which currently are identified as

pkg/polymer/lib/src/transform/common.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** Common methods used by transfomers. */
 library polymer.src.transform.common;
 
 import 'dart:async';
 
 import 'package:barback/barback.dart';
 import 'package:html5lib/dom.dart' show Document;
 import 'package:html5lib/parser.dart' show HtmlParser;
 import 'package:path/path.dart' as path;
 import 'package:source_maps/span.dart' show Span;
 
 /**
  * Parses an HTML file [contents] and returns a DOM-like tree. Adds emitted
  * error/warning to [logger].
  */
 Document parseHtml(String contents, String sourcePath, TransformLogger logger,
-    {bool checkDocType: true}) {
+    {bool checkDocType: false}) {
   // TODO(jmesserly): make HTTP encoding configurable
   var parser = new HtmlParser(contents, encoding: 'utf8', generateSpans: true,
       sourceUrl: sourcePath);
   var document = parser.parse();
 
   // Note: errors aren't fatal in HTML (unless strict mode is on).
   // So just print them as warnings.
   for (var e in parser.errors) {
     if (checkDocType || e.errorCode != 'expected-doctype-but-got-start-tag') {
       logger.warning(e.message, e.span);
@@ skipping 33 matching lines @@
     package = segments[1];
     targetPath = urlBuilder.join('asset',
         urlBuilder.joinAll(segments.sublist(2)));
   } else {
     package = source.package;
     targetPath = urlBuilder.normalize(
         urlBuilder.join(urlBuilder.dirname(source.path), url));
   }
   return new AssetId(package, targetPath);
 }
+
+Future<bool> isHtmlInWebOrTest(AssetId id) =>

[Jennifer Messerly, 2013/09/04 02:35:04]

wondering if we could name this to more reflect what it does (instead of how it
is implemented). Perhaps "isEntryPointHtml" or "isPrimaryHtml" or
"canBePrimaryHtml" (or "nonImportedHtml", "deployedHtml", "publicHtml" ... ? )

[Siggi Cherem (dart-lang), 2013/09/04 16:30:16]

Done. Went with isPrimaryHtml

+    new Future.value(id.extension == '.html' &&

[Jennifer Messerly, 2013/09/04 02:35:04]

hmm. Perhaps add a comment that these are always a package-rooted paths. also
might be good in a public doc comment to mention the convention we are using:
"web" and "test" HTML documents are assumed to be ones that can be loaded
standalone in the browser, and therefore should be deployed.

I was worried about getting tests to run if the structure doesn't match a Dart
package. But since you got the content_shell tests working, it must be okay for
that :)


Unrelated note: do you know why `id.extension` includes the dot?

[Siggi Cherem (dart-lang), 2013/09/04 16:30:16]

Done
Done (added to deploy.dart for now). Note that by default we don't deploy what's
under 'test/' (we don't list it in deploy.dart, only our test script will do so)
I got tests with 'web' directories working, but I have not played with the test/
folder yet. I actually included 'test/' above after I saw your change that adds
support for it. I'm happy to wait and submit this after your CL, that way I
don't add anything that would hold your change any longer =)
I think this is to match what 'package:path' does.

+        (id.path.startsWith('web/') || id.path.startsWith('test/')));