Issue 23478010: Remove deprecated profiler API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23478010: Remove deprecated profiler API (Closed)

Created:
7 years, 3 months ago by yurys

Modified:
7 years, 3 months ago

Reviewers:
Benedikt Meurer, Yang, loislo

CC:
v8-dev, alph

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove deprecated profiler API This change removes --prof-lazy command line flag that was introduced for the old CPU profiler implementation in Chrome DevTools. DevTools now use profiler API defined in v8-profiler.h This change also removes methods for pausing resuming --prof profiler. These methods were deprecated in v.3.20 (https://code.google.com/p/v8/source/browse/branches/3.20/include/v8.h#4629) After this change the profiler will always start if --prof option is passed and can be stopped either in the tests or if write to log file fails. BUG=None R=bmeurer@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16417

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -206 lines)			Patch
M	include/v8.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/cpu-profiler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cpu-profiler.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/log.h	View	2 chunks	+5 lines, -12 lines	0 comments	Download
M	src/log.cc	View	7 chunks	+9 lines, -52 lines	0 comments	Download
M	src/log-utils.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-log.cc	View	11 chunks	+8 lines, -90 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 3 months ago (2013-08-29 10:43:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16417 (presubmit successful).

Expand Messages | Collapse Messages