Check and canonicalize CSS selectors before registering PageStateMatchers.

chrome/renderer/resources/extensions/test_custom_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // test_custom_bindings.js
 // mini-framework for ExtensionApiTest browser tests
 
 var binding = require('binding').Binding.create('test');
 
 var chrome = requireNative('chrome').GetChrome();
@@ skipping 217 matching lines @@
     chromeTest.assertEq(expectedError, chrome.runtime.lastError.message);
   });
 
   apiFunctions.setHandleRequest('assertThrows',
                                 function(fn, self, args, message) {
     chromeTest.assertTrue(typeof fn == 'function');
     try {
       fn.apply(self, args);
       chromeTest.fail('Did not throw error: ' + fn);
     } catch (e) {
-      if (message !== undefined)
+      if (e !== failureException && message !== undefined)

[Jeffrey Yasskin, 2013/08/26 22:35:19]

This is a drive-by fix to improve test failure messages. It was counting a
failed assertThrows() with a message as two failures.

[not at google - send to devlin, 2013/08/27 01:46:14]

All this !== comparing to failureException is rather pointless because
failureException is a non-empty string.

[Jeffrey Yasskin, 2013/08/29 03:39:39]

Do you object to the !==, or is it ok to be consistent with the extra character?

I wound up extending this function much more, so that I can match error messages
with RegExps instead of exactly. Is there a way to say "RegExp" in jsonschema,
or do I really have to use 'any' or the much more verbose "object with test()
function"?

[not at google - send to devlin, 2013/08/29 15:20:25]

Yeah, use != rather than !==. This file is inconsistent.
"isInstanceOf": "RegExp" should do it.

[Jeffrey Yasskin, 2013/08/29 21:46:43]

Done.

         chromeTest.assertEq(message, e.message);
     }
   });
 
   function safeFunctionApply(func, args) {
     try {
       if (func)
         $Function.apply(func, null, args);
     } catch (e) {
       var msg = "uncaught exception " + e;
@@ skipping 67 matching lines @@
   apiFunctions.setHandleRequest('getApiDefinitions', function() {
     return GetExtensionAPIDefinitionsForTest();
   });
 
   apiFunctions.setHandleRequest('getApiFeatures', function() {
     return GetAPIFeatures();
   });
 });
 
 exports.binding = binding.generate();