[OfflinePages, NetworkQualityEstimator] Use NetworkQualityEstimator to decide on triggering Backgro…

net/nqe/network_quality_estimator.h

Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index 248d2089d5ac00583d178efc580ec631920b56bf..d23ec5b0cad8090383a3bde844dbd4007196d01a 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -120,6 +120,21 @@ class NET_EXPORT NetworkQualityEstimator
     DISALLOW_COPY_AND_ASSIGN(ThroughputObserver);
   };
 
+  // Provides simple interface to obtain the effective connection type.
+  class NET_EXPORT NetworkQualityProvider {

[RyanSturm, 2016/09/16 18:54:46]

NetworkQualityEstimator has the same signature for GetEffectiveconnectionType,
so we might want to use this interface for that as well (we could make a core
set of methods that consumers outside of net/ might want to use). Tbansal can
think about that. If we do want to use the interface for NQE, then it might have
to move to the top of the file instead.

[tbansal1, 2016/09/16 19:13:50]

Lets do that later, not now. If we do it, then ideally it should be in
//net/base. Then //net/nqe is just one of the implementors.

[dougarnett, 2016/09/16 21:24:43]

+1  I could add a TODO if you like.

[RyanSturm, 2016/09/19 17:15:40]

Don't worry about adding the TODO. We're not sure yet, and we'll talk about
implementing and expanding this interface to get more functional parity on
IO/UI.

+   public:
+    // Returns the current effective connection type.
+    virtual EffectiveConnectionType GetEffectiveConnectionType() = 0;
+
+    virtual ~NetworkQualityProvider() {}
+
+   protected:
+    NetworkQualityProvider() {}
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(NetworkQualityProvider);
+  };
+
   // Creates a new NetworkQualityEstimator.
   // |variation_params| is the map containing all field trial parameters
   // related to NetworkQualityEstimator field trial.