Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

Issue 2347773002: [LayoutNG] Fix broken layout while using CSS's writing modes. (Closed)
Patch Set: synced to the head Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
index 7895c1d5106fe09a3902c9099cf5df133f419dbb..e5347e2102ff6f6bad6b1f856af09a1537e668ba 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
@@ -25,7 +25,7 @@ class NGLengthUtilsTest : public ::testing::Test {
bool fixed_inline = false,
bool fixed_block = false) {
NGConstraintSpace* derived_constraint_space = new NGConstraintSpace(
- HorizontalTopBottom,
+ HorizontalTopBottom, LeftToRight,
NGLogicalSize(LayoutUnit(inline_size), LayoutUnit(block_size)));
derived_constraint_space->SetOverflowTriggersScrollbar(false, false);
derived_constraint_space->SetFixedSize(fixed_inline, fixed_block);
@@ -210,7 +210,8 @@ TEST_F(NGLengthUtilsTest, testMargins) {
NGConstraintSpace* constraintSpace(ConstructConstraintSpace(200, 300));
- NGBoxStrut margins = computeMargins(*constraintSpace, *style_);
+ NGBoxStrut margins = computeMargins(*constraintSpace, *style_,
+ HorizontalTopBottom, LeftToRight);
EXPECT_EQ(LayoutUnit(20), margins.block_start);
EXPECT_EQ(LayoutUnit(52), margins.inline_end);
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_units.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698