[Blink, RemotePlayback] Reject the prompt() with OperationError if there's a pending promise for th…

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index db5ea01cdad8b43ac1681f4b9835e38fe6a144f2..1a5df02fe56a75efb22bff55c2a21103416cbf48 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -2201,14 +2201,14 @@ void HTMLMediaElement::pauseInternal()
 
 void HTMLMediaElement::requestRemotePlayback()
 {
-    DCHECK(m_remoteRoutesAvailable);
-    webMediaPlayer()->requestRemotePlayback();
+    if (webMediaPlayer())
+        webMediaPlayer()->requestRemotePlayback();

[mlamouri (slow - plz ping), 2016/09/22 09:22:43]

Why this change?

[whywhat, 2016/09/22 13:18:27]

With the gesture requirement removed, it's possible to call prompt() before the
webMediaPlayer() is initialized for local playback.

[whywhat, 2016/09/30 19:11:33]

I think that from the test it's possible to call prompt() before the
webMediaPlayer() is initialized.

[mlamouri (slow - plz ping), 2016/10/01 14:55:53]

Does that mean that we are dropping on the floor the call if webMediaPlayer()
wasn't initialised yet?

[whywhat, 2016/10/03 20:39:00]

Yes, this will change once we stop forwarding this calls to webMediaPlayer() and
handle them in RemotePlayback

 }
 
 void HTMLMediaElement::requestRemotePlaybackControl()
 {
-    DCHECK(m_remoteRoutesAvailable);
-    webMediaPlayer()->requestRemotePlaybackControl();
+    if (webMediaPlayer())
+        webMediaPlayer()->requestRemotePlaybackControl();

[mlamouri (slow - plz ping), 2016/09/22 09:22:43]

ditto

[whywhat, 2016/09/30 19:11:33]

ditto.

 }
 
 void HTMLMediaElement::closeMediaSource()