Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html

Issue 2347763002: [Blink, RemotePlayback] Reject the prompt() with OperationError if there's a pending promise for th… (Closed)
Patch Set: Added UserGesture flag for tests, removed some checks in HTMLMediaElement, added layout test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html
diff --git a/third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-prompt-throws.html b/third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html
similarity index 78%
copy from third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-prompt-throws.html
copy to third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html
index 143456587902254c92aa00c145be929d9f6cf7d7..367f69dba210c2e9d801a7da6b05648ab2c8862a 100644
--- a/third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-prompt-throws.html
+++ b/third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html
@@ -10,14 +10,16 @@
<script>
promise_test(function(test)
{
+ internals.settings.setRemotePlaybackRequiresUserGesture(false);
mlamouri (slow - plz ping) 2016/09/22 09:22:43 nstead, I think you can wrap this with a method th
whywhat 2016/09/30 19:11:33 Done. I anticipate the flag to be needed by integr
var v = document.createElement('video');
v.src = findMediaFile('video', 'content/test');
- v.disableRemotePlayback = true
document.body.appendChild(v);
+ v.remote.prompt();
+
return promise_rejects(
test,
- new DOMException('disableRemotePlayback attribute is present.', 'InvalidStateError'),
+ new DOMException('A prompt is already being shown for this media element.', 'OperationError'),
v.remote.prompt());
}, 'Test that calling prompt() when disableRemotePlayback attribute is set throws an exception.');
</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Settings.in » ('j') | third_party/WebKit/Source/core/frame/Settings.in » ('J')

Powered by Google App Engine
This is Rietveld 408576698