third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html - Issue 2347763002: [Blink, RemotePlayback] Reject the prompt() with OperationError if there's a pending promise for th…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html

Issue 2347763002: [Blink, RemotePlayback] Reject the prompt() with OperationError if there's a pending promise for th… (Closed)

Patch Set: Addressed Mounir's comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Test that calling prompt() before the promise returned by the pre vious call is resolved throws an exception</title>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 <script src="../media-file.js"></script>

	8 </head>

	9 <body>

	10 <script>

	11 async_test(function(test)

	12 {

	13 var v = document.createElement('video');

	14 v.src = findMediaFile('video', 'content/test');

	15 document.body.appendChild(v);

	16

	17 document.onclick = function() {

	18 v.remote.prompt();

	19

	20 v.remote.prompt().then(
	mlamouri (slow - plz ping) 2016/10/01 14:55:53 Maybe you should have another simulated user gestu Maybe you should have another simulated user gesture? Otherwise, I think your test only passes because of the check for the popup already open happening before the utiliseUserGesture check. whywhat 2016/10/03 20:39:01 Hm, if the checks are reversed, the utiliseUserGes Show quoted text On 2016/10/01 at 14:55:53, mlamouri wrote: > Maybe you should have another simulated user gesture? Otherwise, I think your test only passes because of the check for the popup already open happening before the utiliseUserGesture check. Hm, if the checks are reversed, the utiliseUserGesture would still work since we call prompt() twice from the same handler, no?
	21 test.unreached_func(),

	22 test.step_func_done(function(e) {

	23 assert_equals(e.name, 'OperationError');

	24 assert_equals(e.message, 'A prompt is already being shown for this media element.');

	25 }));

	26 document.onclick = null;

	27 }

	28

	29 eventSender.mouseDown();

	30 eventSender.mouseUp();
	mlamouri (slow - plz ping) 2016/10/01 14:55:53 Having a <button>click me</button> as a target wou Having a <button>click me</button> as a target would be better because it makes this test sharable with w3c. whywhat 2016/10/03 20:39:01 Alright. I'll try to remember to point noone to th Show quoted text On 2016/10/01 at 14:55:53, mlamouri wrote: > Having a <button>click me</button> as a target would be better because it makes this test sharable with w3c. Alright. I'll try to remember to point noone to the play promise test example then :) (unless someone fixes it?)
	31 }, 'Test that calling prompt() before the promise returned by the pr evious call is resolved throws an exception.');

	32 </script>

	33 </body>

	34 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »