Adds histograms for tracking Software Reporter logs uploads in SRT Fetcher.

chrome/browser/safe_browsing/srt_fetcher_win.h

Index: chrome/browser/safe_browsing/srt_fetcher_win.h
diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.h b/chrome/browser/safe_browsing/srt_fetcher_win.h
index 1ff81f3980caa5bfd82bef1258a706b170a81b07..b5391bab8e1ce8b1f9813b397af013173181e0f9 100644
--- a/chrome/browser/safe_browsing/srt_fetcher_win.h
+++ b/chrome/browser/safe_browsing/srt_fetcher_win.h
@@ -59,17 +59,21 @@ struct SwReporterInvocation {
   // ending in |suffix|. For the canonical version, |suffix| will be empty.
   std::string suffix;
 
-  // Flags to control optional behaviours. By default all are enabled;
-  // experimental versions of the reporter will turn off the behaviours that
-  // are not yet supported.
-  using Flags = uint32_t;
-  enum : Flags {
-    FLAG_LOG_TO_RAPPOR = 0x1,
-    FLAG_LOG_EXIT_CODE_TO_PREFS = 0x2,
-    FLAG_TRIGGER_PROMPT = 0x4,
-    FLAG_SEND_REPORTER_LOGS = 0x8,
+  // Flags to control behaviours the Software Reporter should support by
+  // default. These flags are set in the Reporter installer, and experimental
+  // versions of the reporter will turn off the behaviours that are not yet
+  // supported.
+  using ReporterBehaviours = uint32_t;

[Joe Mason, 2016/09/16 14:57:13]

This could just be called "Behaviours" and the flags start with BEHAVIOUR_,
since they're already in the SwReporterInvocation class it's clear they're
talking about the reporter. And the enum names get pretty long.

[ftirelo, 2016/09/16 15:34:42]

Done.

+  enum : ReporterBehaviours {
+    REPORTER_BEHAVIOUR_LOG_TO_RAPPOR = 0x1,
+    REPORTER_BEHAVIOUR_LOG_EXIT_CODE_TO_PREFS = 0x2,
+    REPORTER_BEHAVIOUR_TRIGGER_PROMPT = 0x4,
+    REPORTER_BEHAVIOUR_SEND_REPORTER_LOGS = 0x8,
   };
-  Flags flags = 0;
+  ReporterBehaviours supported_behaviours = 0;
+
+  // Whether logs upload was enabled in this invocation.
+  bool logs_upload_enabled = false;
 
   SwReporterInvocation();