Issue 23477075: Rename isolateFor*() utility functions to toIsolate()

Issue 23477075: Rename isolateFor*() utility functions to toIsolate() (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
haraken, abarth-chromium, pfeldman, marja

CC:
blink-reviews, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename isolateFor*() utility functions to toIsolate() Rename isolateFor*() utility functions to toIsolate() and leverage C++ overloading instead of having separate method names for each kind of input. R=abarth BUG=263412 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157887

Patch Set 1 #

Patch Set 2 : Rebase on master #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -38 lines)			Patch
M	Source/bindings/scripts/deprecated_code_generator_v8.pm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/templates/callback_interface.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestCallback.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/DOMRequestState.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScriptEventListener.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/ScriptState.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8Binding.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/V8Binding.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp	View	1	5 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/bindings/v8/V8LazyEventListener.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/inspector/InspectorIndexedDBAgent.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorOverlay.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebDevToolsFrontendImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebFrameImpl.cpp	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/web/tests/CustomEventTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

do-not-use

As proposed by Adam Barth in: https://codereview.chromium.org/23876015/#msg12

7 years, 3 months ago (2013-09-15 08:48:37 UTC) #1

do-not-use

abarth@ or pfeldman@, could you please take a look for Source/web?

7 years, 3 months ago (2013-09-17 06:45:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23477075/7001

7 years, 3 months ago (2013-09-17 07:01:24 UTC) #6

Message was sent while issue was closed.

Change committed as 157887

Expand Messages | Collapse Messages