Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 23477069: Add the supervised user placholder icon (Closed)

Created:
7 years, 3 months ago by ibra
Modified:
7 years, 3 months ago
Reviewers:
oshima, Sergiu
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add the supervised user placholder icon. It will be displayed on the managed user import overlay for managed users with no stored avatar. BUG=291021 R=oshima@chromium.org, sergiu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223319

Patch Set 1 #

Patch Set 2 : .. #

Patch Set 3 : oshima@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A chrome/app/theme/default_100_percent/common/supervised_user_placeholder.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/supervised_user_placeholder.png View 1 2 Binary file 0 comments Download

Messages

Total messages: 10 (0 generated)
ibra
Sergiu, please review. Thanks!
7 years, 3 months ago (2013-09-12 09:43:45 UTC) #1
Sergiu
lgtm
7 years, 3 months ago (2013-09-13 16:16:41 UTC) #2
ibra
Hi Oshima, Can I have an OWNERS review for this CL? Thanks!
7 years, 3 months ago (2013-09-13 16:24:53 UTC) #3
oshima
Don't you have a bug for this? If not, can you file one? Is this ...
7 years, 3 months ago (2013-09-13 16:50:35 UTC) #4
ibra
On 2013/09/13 16:50:35, oshima wrote: > Don't you have a bug for this? If not, ...
7 years, 3 months ago (2013-09-13 17:11:00 UTC) #5
oshima
lgtm
7 years, 3 months ago (2013-09-13 17:38:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/23477069/12001
7 years, 3 months ago (2013-09-13 17:43:08 UTC) #7
oshima
On 2013/09/13 17:43:08, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 3 months ago (2013-09-13 17:48:58 UTC) #8
ibra
On 2013/09/13 17:48:58, oshima wrote: > On 2013/09/13 17:43:08, I haz the power (commit-bot) wrote: ...
7 years, 3 months ago (2013-09-13 17:51:01 UTC) #9
Sergiu
7 years, 3 months ago (2013-09-16 09:00:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r223319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698