Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2799)

Unified Diff: remoting/proto/video.proto

Issue 23477059: Simplify VideoEncoder interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/video_scheduler_unittest.cc ('k') | remoting/protocol/protobuf_video_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/proto/video.proto
diff --git a/remoting/proto/video.proto b/remoting/proto/video.proto
index b412857773cdf0b5d5c3e6f3ee9b35b3300e6aa7..0ee5c975a6a282cff999195e7bf7b094b5f7a896 100644
--- a/remoting/proto/video.proto
+++ b/remoting/proto/video.proto
@@ -19,17 +19,9 @@ message VideoPacketFormat {
ENCODING_VP8 = 2;
};
- // X,Y coordinates (in screen pixels) for origin of this update.
- optional int32 x = 1;
- optional int32 y = 2;
-
- // Width, height (in screen pixels) for this update.
- optional int32 width = 3;
- optional int32 height = 4;
-
// The encoding used for this image update.
optional Encoding encoding = 5 [default = ENCODING_INVALID];
-
+
// Width and height of the whole screen.
optional int32 screen_width = 6;
optional int32 screen_height = 7;
@@ -49,45 +41,14 @@ message Rect {
}
message VideoPacket {
- // Bitmasks for use in the flags field below.
- //
- // The encoder may fragment one update into multiple partitions.
- // Each partition may be divided into multiple packets depending on
- // how the encoder outputs data. Thus, one update can logically
- // consist of multiple packets. The FIRST_PACKET and LAST_PACKET
- // flags are used to indicate the start and end of a partition. The
- // LAST_PARTITION flag is set for the last packet in the last
- // partition. Here are notable consequences:
- // * Both FIRST_PACKET and LAST_PACKET may be set if an update is only
- // one packet long.
- // * The VideoPacketFormat is only supplied in a FIRST_PACKET.
- // * LAST_PARTITION can be set only in packet that has LAST_PACKET set.
- // * An local update cannot change format between a FIRST_PACKET and
- // a LAST_PACKET.
- // * All packets in one logical update must be processed in order, and
- // packets may not be skipped.
- enum Flags {
- FIRST_PACKET = 1;
- LAST_PACKET = 2;
- LAST_PARTITION = 4;
- }
- optional int32 flags = 1 [default = 0];
-
- // The sequence number of the partial data for updating a rectangle.
- optional int32 sequence_number = 2 [default = 0];
-
- optional int32 timestamp = 3 [default = 0];
-
- // This is provided on the first packet of the rectangle data, when
- // the flags has FIRST_PACKET set.
+ // Deprecated. Must be set to 7 for backward compatibility.
+ optional int32 deprecated_flags = 1 [default = 7];
+
optional VideoPacketFormat format = 4;
optional bytes data = 5;
- // This field is only for VP8 to provide out-of-band information of dirty
- // rects.
- // TODO(hclam): Remove this field when we can obtain this information from
- // libvpx.
+ // List of rectangles updated by this frame.
repeated Rect dirty_rects = 6;
// Time in milliseconds spent in capturing this video frame.
« no previous file with comments | « remoting/host/video_scheduler_unittest.cc ('k') | remoting/protocol/protobuf_video_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698