Issue 23477048: Media query malformed when 'or' is used as a media type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23477048: Media query malformed when 'or' is used as a media type. (Closed)

Created:
7 years, 3 months ago by rune

Modified:
7 years, 2 months ago

Reviewers:
TabAtkins, apavlov, SeRya

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Media query malformed when 'or' is used as a media type. The Media Queries errata[1] dated 2013-06-27 includes 'or' in the list of reserved keywords that will result in a malformed media query instead of an unknown media type when used as a media type. [1] http://www.w3.org/Style/2012/REC-mediaqueries-20120619-errata.html BUG=288213 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158713

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -0 lines)			Patch
A	LayoutTests/fast/media/mq-invalid-media-type.html	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/media/mq-invalid-media-type-expected.html	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSGrammar.y.in	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/CSSParser-in.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23477048/1

7 years, 2 months ago (2013-10-02 09:46:06 UTC) #6

Message was sent while issue was closed.

Change committed as 158713