Issue 23477040: Revert 221410 "Add ManagedUserSettingsService and a SupervisedUs..."

Issue 23477040: Revert 221410 "Add ManagedUserSettingsService and a SupervisedUs..." (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)

Modified:
7 years, 3 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 221410 "Add ManagedUserSettingsService and a SupervisedUs..." Broke Linux ChromiumOS Tests (1): http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%281%29&number=32217 > Add ManagedUserSettingsService and a SupervisedUserPrefStore using it. > > BUG=280674 > > Review URL: https://chromiumcodereview.appspot.com/23466004 TBR=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221411

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -813 lines)			Patch
D	trunk/src/chrome/browser/managed_mode/managed_user_constants.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/managed_user_constants.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/managed_user_settings_service.h	View	1 chunk	+0 lines, -120 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/managed_user_settings_service.cc	View	1 chunk	+0 lines, -158 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/managed_user_settings_service_factory.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/managed_user_settings_service_factory.cc	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/managed_user_settings_service_unittest.cc	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/supervised_user_pref_store.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/supervised_user_pref_store.cc	View	1 chunk	+0 lines, -124 lines	0 comments	Download
D	trunk/src/chrome/browser/managed_mode/supervised_user_pref_store_unittest.cc	View	1 chunk	+0 lines, -171 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser.gypi	View	3 chunks	+1 line, -9 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

7 years, 3 months ago (2013-09-05 16:50:34 UTC) #3

Message was sent while issue was closed.

That's... weird. Note that the CL only adds files and tests, it does not change
the behavior of existing code. So the only way I could my CL causing the failure
would be if it somehow messed up some global state or corrupts some memory that
only manifests with that particular test.

Philipp, would you mind if I reland this CL to see if it was just a messed up
build?

Expand Messages | Collapse Messages