Issue 23477038: Misc clean up for Drive API service and requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23477038: Misc clean up for Drive API service and requests. (Closed)

Created:
7 years, 3 months ago by hidehiko

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Misc clean up for Drive API service and requests. - Remove unused ContinueGetFileListRequest. - Remove unused Parse functions from drive_api_service. - Rename remaining "Parse" functions in drive_api_service to "Convert" functions to adapt its behavior more. BUG=277253, 275233 TEST=Ran unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221363

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -136 lines)			Patch
M	chrome/browser/drive/drive_api_service.cc	View	6 chunks	+9 lines, -69 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.h	View	4 chunks	+2 lines, -23 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests_unittest.cc	View	1 chunk	+0 lines, -27 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23477038/1

7 years, 3 months ago (2013-09-05 03:09:46 UTC) #3

commit-bot: I haz the power

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82981

7 years, 3 months ago (2013-09-05 03:47:57 UTC) #4

hidehiko

7 years, 3 months ago (2013-09-05 07:37:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r221363 (presubmit successful).

Expand Messages | Collapse Messages