Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_tasks.h

Issue 23477036: file_manager: getFileTasks() to return Drive apps iff all files are on Drive (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/file_tasks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_manager/file_tasks.h
diff --git a/chrome/browser/chromeos/extensions/file_manager/file_tasks.h b/chrome/browser/chromeos/extensions/file_manager/file_tasks.h
index 0cb6b93acf2539af5ae1e63252508b315dc8524e..d9ec2a9dc397e01e416a117183ed0887b3bc39a6 100644
--- a/chrome/browser/chromeos/extensions/file_manager/file_tasks.h
+++ b/chrome/browser/chromeos/extensions/file_manager/file_tasks.h
@@ -180,7 +180,6 @@ class FullTaskDescriptor {
// Returns a DictionaryValue representation, which looks like:
//
// {
- // "driveApp": true,
// "iconUrl": "<app_icon_url>",
// "isDefault": false,
// "taskId": "<drive_app_id>|drive|open-with",
@@ -270,8 +269,9 @@ bool ExecuteFileTask(Profile* profile,
typedef extensions::app_file_handler_util::PathAndMimeTypeSet
PathAndMimeTypeSet;
-// Finds the drive app tasks that can be used with the given |path_mime_set|
+// Finds the Drive app tasks that can be used with the given |path_mime_set|
// from |drive_app_registry|, and append them to the |result_list|.
+// Drive app tasks will be found only if all of the files are on Drive.
void FindDriveAppTasks(const drive::DriveAppRegistry& drive_app_registry,
const PathAndMimeTypeSet& path_mime_set,
std::vector<FullTaskDescriptor>* result_list);
@@ -293,6 +293,7 @@ void FindFileBrowserHandlerTasks(
// Finds all types (drive, file handlers, file browser handlers) of
// tasks. See the comment at FindDriveAppTasks() about |result_list|.
+// Drive app tasks will be found only if all of the files are on Drive.
void FindAllTypesOfTasks(
Profile* profile,
const PathAndMimeTypeSet& path_mime_set,
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/file_tasks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698