file_manager: getFileTasks() to return Drive apps iff all files are on Drive

chrome/browser/chromeos/extensions/file_manager/file_tasks.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/file_tasks.h"
 
 #include "apps/launcher.h"
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chromeos/drive/drive_app_registry.h"
 #include "chrome/browser/chromeos/drive/drive_integration_service.h"
+#include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/drive/file_task_executor.h"
 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.h"
 #include "chrome/browser/chromeos/extensions/file_manager/fileapi_util.h"
 #include "chrome/browser/chromeos/extensions/file_manager/open_util.h"
 #include "chrome/browser/chromeos/fileapi/file_system_backend.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_system.h"
@@ skipping 101 matching lines @@
       icon_url_(icon_url),
       is_default_(is_default){
 }
 
 scoped_ptr<base::DictionaryValue>
 FullTaskDescriptor::AsDictionaryValue() const {
   scoped_ptr<base::DictionaryValue> dictionary(new base::DictionaryValue);
   dictionary->SetString("taskId", TaskDescriptorToId(task_descriptor_));
   if (!icon_url_.is_empty())
     dictionary->SetString("iconUrl", icon_url_.spec());
-  dictionary->SetBoolean("driveApp",
-                         task_descriptor_.task_type == TASK_TYPE_DRIVE_APP);
   dictionary->SetString("title", task_title_);
   dictionary->SetBoolean("isDefault", is_default_);
   return dictionary.Pass();
 }
 
 void UpdateDefaultTask(PrefService* pref_service,
                        const std::string& task_id,
                        const std::set<std::string>& suffixes,
                        const std::set<std::string>& mime_types) {
   if (!pref_service)
@@ skipping 166 matching lines @@
   DCHECK(result_list);
 
   bool is_first = true;
   typedef std::map<std::string, drive::DriveAppInfo> DriveAppInfoMap;
   DriveAppInfoMap drive_app_map;
 
   for (PathAndMimeTypeSet::const_iterator it = path_mime_set.begin();
        it != path_mime_set.end(); ++it) {
     const base::FilePath& file_path = it->first;
     const std::string& mime_type = it->second;
-    if (file_path.empty())
-      continue;
+    // Return immediately if a file not on Drive is found, as Drive app tasks
+    // work only if all files are on Drive.
+    if (!drive::util::IsUnderDriveMountPoint(file_path))
+      return;
 
     ScopedVector<drive::DriveAppInfo> app_info_list;
     drive_app_registry.GetAppsForFile(file_path.Extension(),
                                       mime_type,
                                       &app_info_list);
 
     if (is_first) {
       // For the first file, we store all the info.
       for (size_t j = 0; j < app_info_list.size(); ++j) {
         const drive::DriveAppInfo& app_info = *app_info_list[j];
@@ skipping 216 matching lines @@
     if (file_browser_handlers::IsFallbackFileBrowserHandler(
             task->task_descriptor())) {
       task->set_is_default(true);
       return;
     }
   }
 }
 
 }  // namespace file_tasks
 }  // namespace file_manager