Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/history/url_utils_unittest.cc

Issue 23477033: Implementing URL prefix match for history thumbnail cache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Inlining; comment fixes. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/url_utils_unittest.cc
diff --git a/chrome/browser/history/url_utils_unittest.cc b/chrome/browser/history/url_utils_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d91534b1ef11e8c65cc0c92f74539a6ec330d47d
--- /dev/null
+++ b/chrome/browser/history/url_utils_unittest.cc
@@ -0,0 +1,92 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/history/url_utils.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace history {
+
+namespace {
+
+TEST(UrlUtilsTest, CanonicalURLStringCompare) {
+ // Comprehensive test by comparing each pair in sorted list. O(n^2).
+ const char* sorted_list[] = {
+ "http://www.gogle.com/redirects_to_google",
+ "http://www.google.com",
+ "http://www.google.com/",
+ "http://www.google.com/?q",
+ "http://www.google.com/A",
+ "http://www.google.com/index.html",
+ "http://www.google.com/test",
+ "http://www.google.com/test?query",
+ "http://www.google.com/test?r=3",
+ "http://www.google.com/test#hash",
+ "http://www.google.com/test/?query",
+ "http://www.google.com/test/#hash",
+ "http://www.google.com/test/zzzzz",
+ "http://www.google.com/test$dollar",
+ "http://www.google.com/test%E9%9B%80",
+ "http://www.google.com/test-case",
+ "http://www.google.com:80/",
+ "https://www.google.com",
+ };
+ for (int i = 0; i < arraysize(sorted_list); ++i) {
+ EXPECT_FALSE(CanonicalURLStringCompare(sorted_list[i], sorted_list[i]))
+ << " for \"" << sorted_list[i] << "\" < \"" << sorted_list[i] << "\"";
+ // Every disjoint pair-wise comparison.
+ for (int j = i + 1; j < arraysize(sorted_list); ++j) {
+ EXPECT_TRUE(CanonicalURLStringCompare(sorted_list[i], sorted_list[j]))
+ << " for \"" << sorted_list[i] << "\" < \"" << sorted_list[j] << "\"";
+ EXPECT_FALSE(CanonicalURLStringCompare(sorted_list[j], sorted_list[i]))
+ << " for \"" << sorted_list[j] << "\" < \"" << sorted_list[i] << "\"";
+ }
+ }
+}
+
+TEST(UrlUtilsTest, UrlIsPrefix) {
+ struct {
+ const char* s1;
+ const char* s2;
+ } true_cases[] = {
+ {"http://www.google.com", "http://www.google.com"},
+ {"http://www.google.com/a/b", "http://www.google.com/a/b"},
+ {"http://www.google.com?test=3", "http://www.google.com/"},
+ {"http://www.google.com/#hash", "http://www.google.com/?q"},
+ {"http://www.google.com/", "http://www.google.com/test/with/dir/"},
+ {"http://www.google.com:360", "http://www.google.com:360/?q=1234"},
+ {"http://www.google.com:80", "http://www.google.com/gurl/is/smart"},
+ {"http://www.google.com:80/", "http://www.google.com/"},
+ {"http://www.google.com/test", "http://www.google.com/test/with/dir/"},
+ {"http://www.google.com/test/", "http://www.google.com/test/with/dir"},
+ {"http://www.google.com/test?", "http://www.google.com/test/with/dir/"},
+ };
+ for (int i = 0; i < arraysize(true_cases); ++i) {
+ EXPECT_TRUE(UrlIsPrefix(GURL(true_cases[i].s1), GURL(true_cases[i].s2)))
+ << " for true_cases[" << i << "]";
+ }
+ struct {
+ const char* s1;
+ const char* s2;
+ } false_cases[] = {
+ {"http://www.google.com/test", "http://www.google.com"},
+ {"http://www.google.com/a/b/", "http://www.google.com/a/b"}, // Arguable.
+ {"http://www.google.co", "http://www.google.com"},
+ {"http://google.com", "http://www.google.com"},
+ {"http://www.google.com", "https://www.google.com"},
+ {"http://www.google.com/path", "http://www.google.com:137/path"},
+ {"http://www.google.com/same/dir", "http://www.youtube.com/same/dir"},
+ {"http://www.google.com/te", "http://www.google.com/test"},
+ {"http://www.google.com/test", "http://www.google.com/test-bed"},
+ {"http://www.google.com/test-", "http://www.google.com/test?"},
+ };
+ for (int i = 0; i < arraysize(false_cases); ++i) {
+ EXPECT_FALSE(UrlIsPrefix(GURL(false_cases[i].s1), GURL(false_cases[i].s2)))
+ << " for false_cases[" << i << "]";
+ }
+}
+
+} // namespace
+
+} // namespace history

Powered by Google App Engine
This is Rietveld 408576698