Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: chrome/browser/history/top_sites.h

Issue 23477033: Implementing URL prefix match for history thumbnail cache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding url_utils.*; adding chrome://thumb2; refactoring. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/top_sites.h
diff --git a/chrome/browser/history/top_sites.h b/chrome/browser/history/top_sites.h
index 6d57d1216f6fdc0c060c6943f198bf9190e2d921..4fb55c83c05227303dfddaaf546663792cf2c6d1 100644
--- a/chrome/browser/history/top_sites.h
+++ b/chrome/browser/history/top_sites.h
@@ -73,10 +73,14 @@ class TopSites
// Get a thumbnail for a given page. Returns true iff we have the thumbnail.
// This may be invoked on any thread.
+ // If an exact thumbnail URL match fails, |prefix_match| specifies whether or
+ // not to try harder by matching the query thumbnail URL as URL prefix.
sky 2013/09/12 21:22:18 Clarify exactly what 'prefix' here means.
huangs 2013/09/12 23:33:47 Referring to UrlIsPrefix() in url_utils.h; adding
// As this method may be invoked on any thread the ref count needs to be
// incremented before this method returns, so this takes a scoped_refptr*.
virtual bool GetPageThumbnail(
- const GURL& url, scoped_refptr<base::RefCountedMemory>* bytes) = 0;
+ const GURL& url,
+ bool prefix_match,
+ scoped_refptr<base::RefCountedMemory>* bytes) = 0;
// Get a thumbnail score for a given page. Returns true iff we have the
// thumbnail score. This may be invoked on any thread. The score will

Powered by Google App Engine
This is Rietveld 408576698