Limit the Material Design OOBE in a way that is less fragile.

Limit the Material Design OOBE in a way that is less fragile.

Currently the MD OOBE is enabled in a few different code paths, which unfortunately breaks when using, for example, zero-touch; or any path where enterprise enrollment is a possibility (as the login controller will jump straight into the network screen, bypassing the logic to determine whether to use the MD OOBE or not).

Instead, disable it for the few cases we know we have not tested (CfM and any device needing the HID screen).

Moreover, let's make sure that the MD/non-MD logic works when someone uses magic keys like CTRL+ALT+H to restart setup as a CfM.

This CL does not change the way local state stores whether to use MD or not, which is still a default of not showing it if state is not carefully set.

BUG=647365
TEST=manual (many combinations with and without existing local state)

Committed: https://crrev.com/09be0185e0f17c0803e589861eb8518c9bd04c8a
Cr-Commit-Position: refs/heads/master@{#419518}

[The one and only Dr. Crash, 2016-09-15 21:45:18]

drcrash@chromium.org changed reviewers:
+ alemate@chromium.org, xiyuan@google.com

[The one and only Dr. Crash, 2016-09-17 20:08:55]

Description was changed from

==========
Limit the Material Design OOBE in a way that is less fragile.

Currently the MD OOBE is enabled in a few different code paths, which
unfortunately breaks when using, for example, zero-touch. Instead,
disable it for the few cases we know we have not tested (CfM and any
device needing the HID screen).

Moreover, let's make sure that the MD/non-MD logic works when someone
uses magic keys like CTRL+ALT+H to restart setup as a CfM.

BUG=647365
TEST=manual (many combinations with and without existing local state)
==========

to

==========
Limit the Material Design OOBE in a way that is less fragile.

Currently the MD OOBE is enabled in a few different code paths, which
unfortunately breaks when using, for example, zero-touch; or any path where
enterprise enrollment is a possibility (as the login controller will jump
straight into the network screen, bypassing the logic to determine whether to
use the MD OOBE or not).

Instead, disable it for the few cases we know we have not tested (CfM and any
device needing the HID screen).

Moreover, let's make sure that the MD/non-MD logic works when someone uses magic
keys like CTRL+ALT+H to restart setup as a CfM.

This CL does not change the way local state stores whether to use MD or not,
which is still a default of not showing it if state is not carefully set.

BUG=647365
TEST=manual (many combinations with and without existing local state)
==========

[Alexander Alekseev, 2016-09-18 11:50:45]

lgtm with nit

https://codereview.chromium.org/2347703002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/2347703002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wizard_controller.cc:329:
chromeos::switches::kDisableMdOobe))
Please, add {} as we have more than one branch here.

[The one and only Dr. Crash, 2016-09-19 18:10:52]

The CQ bit was checked by drcrash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:11:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[The one and only Dr. Crash, 2016-09-19 18:13:27]

The CQ bit was unchecked by drcrash@chromium.org

[The one and only Dr. Crash, 2016-09-19 18:13:33]

The CQ bit was checked by drcrash@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:13:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:45:18]

Description was changed from

==========
Limit the Material Design OOBE in a way that is less fragile.

Currently the MD OOBE is enabled in a few different code paths, which
unfortunately breaks when using, for example, zero-touch; or any path where
enterprise enrollment is a possibility (as the login controller will jump
straight into the network screen, bypassing the logic to determine whether to
use the MD OOBE or not).

Instead, disable it for the few cases we know we have not tested (CfM and any
device needing the HID screen).

Moreover, let's make sure that the MD/non-MD logic works when someone uses magic
keys like CTRL+ALT+H to restart setup as a CfM.

This CL does not change the way local state stores whether to use MD or not,
which is still a default of not showing it if state is not carefully set.

BUG=647365
TEST=manual (many combinations with and without existing local state)
==========

to

==========
Limit the Material Design OOBE in a way that is less fragile.

Currently the MD OOBE is enabled in a few different code paths, which
unfortunately breaks when using, for example, zero-touch; or any path where
enterprise enrollment is a possibility (as the login controller will jump
straight into the network screen, bypassing the logic to determine whether to
use the MD OOBE or not).

Instead, disable it for the few cases we know we have not tested (CfM and any
device needing the HID screen).

Moreover, let's make sure that the MD/non-MD logic works when someone uses magic
keys like CTRL+ALT+H to restart setup as a CfM.

This CL does not change the way local state stores whether to use MD or not,
which is still a default of not showing it if state is not carefully set.

BUG=647365
TEST=manual (many combinations with and without existing local state)
==========

[commit-bot: I haz the power, 2016-09-19 18:45:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-19 18:47:32]

Description was changed from

==========
Limit the Material Design OOBE in a way that is less fragile.

Currently the MD OOBE is enabled in a few different code paths, which
unfortunately breaks when using, for example, zero-touch; or any path where
enterprise enrollment is a possibility (as the login controller will jump
straight into the network screen, bypassing the logic to determine whether to
use the MD OOBE or not).

Instead, disable it for the few cases we know we have not tested (CfM and any
device needing the HID screen).

Moreover, let's make sure that the MD/non-MD logic works when someone uses magic
keys like CTRL+ALT+H to restart setup as a CfM.

This CL does not change the way local state stores whether to use MD or not,
which is still a default of not showing it if state is not carefully set.

BUG=647365
TEST=manual (many combinations with and without existing local state)
==========

to

==========
Limit the Material Design OOBE in a way that is less fragile.

Currently the MD OOBE is enabled in a few different code paths, which
unfortunately breaks when using, for example, zero-touch; or any path where
enterprise enrollment is a possibility (as the login controller will jump
straight into the network screen, bypassing the logic to determine whether to
use the MD OOBE or not).

Instead, disable it for the few cases we know we have not tested (CfM and any
device needing the HID screen).

Moreover, let's make sure that the MD/non-MD logic works when someone uses magic
keys like CTRL+ALT+H to restart setup as a CfM.

This CL does not change the way local state stores whether to use MD or not,
which is still a default of not showing it if state is not carefully set.

BUG=647365
TEST=manual (many combinations with and without existing local state)

Committed: https://crrev.com/09be0185e0f17c0803e589861eb8518c9bd04c8a
Cr-Commit-Position: refs/heads/master@{#419518}
==========

[commit-bot: I haz the power, 2016-09-19 18:47:33]

Patchset 1 (id:??) landed as
https://crrev.com/09be0185e0f17c0803e589861eb8518c9bd04c8a
Cr-Commit-Position: refs/heads/master@{#419518}