Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 23477026: Make OperationID usable for error handling. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
kinuko
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, kinaba
Visibility:
Public.

Description

Make OperationID usable for error handling. Currently, a callback can be called before the FileSystemOperationRunner's method returns OperationID. So, it is difficult to use OperationID inside the callback. This CL makes two changes: - Methods start to return valid OperationID even if the running operation fails. - Callbacks will be invoked at least in the next message loop. Then, the caller of FileSystemOperationRunner's methods can know OperationID before the callback is invoked, and use it in callbacks. BUG=279288 TEST=Ran unit_tests content_unittests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -153 lines) Patch
M webkit/browser/fileapi/file_system_operation_runner.h View 2 chunks +1 line, -3 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_runner.cc View 27 chunks +158 lines, -150 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 3 months ago (2013-09-02 12:00:11 UTC) #1
kinuko
lgtm
7 years, 3 months ago (2013-09-03 00:58:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23477026/1
7 years, 3 months ago (2013-09-03 01:01:57 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=150757
7 years, 3 months ago (2013-09-03 03:37:22 UTC) #4
hidehiko
7 years, 3 months ago (2013-09-06 06:55:13 UTC) #5
On 2013/09/03 03:37:22, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_chromeos for step(s) browser_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Closing as r221384 is landed.
Thank you for your work, Kinuko!

- hidehiko

Powered by Google App Engine
This is Rietveld 408576698