Issue 23477024: media: Uploading the correct test file for Opus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23477024: media: Uploading the correct test file for Opus (Closed)

Created:
7 years, 3 months ago by vignesh

Modified:
7 years, 3 months ago

Reviewers:
xhwang, Tom Finegan

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

media: Uploading the correct test file for Opus Somehow i ended up uploading a 0-byte file before. Now updating media/test/data/bear-opus-end-trimming.webm with the correct file. It's probably because i tried to upload both the binary file and the README in the same CL. R=tomfinegan@chromium.org, xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220423

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	M	media/test/data/bear-opus-end-trimming.webm	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 5 (0 generated)

vignesh

On 2013/08/29 23:05:56, xhwang wrote: > lgtm, you'll need to dcommit the binary. okay, thanks. ...

7 years, 3 months ago (2013-08-29 23:06:51 UTC) #4

fgalligan1

7 years, 3 months ago (2013-08-29 23:14:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r220423 (presubmit successful).