Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2347683002: Roll ANGLE 09cfac6..415f29e (Closed)

Created:
4 years, 3 months ago by Corentin Wallez
Modified:
4 years, 3 months ago
Reviewers:
Geoff Lang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ANGLE 09cfac6..415f29e https://chromium.googlesource.com/angle/angle.git/+log/09cfac6..415f29e BUG= TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/ac2a4e916123d43293eb9d47e31b469045ca068e Cr-Commit-Position: refs/heads/master@{#418995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347683002/1
4 years, 3 months ago (2016-09-15 20:11:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 21:53:07 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac2a4e916123d43293eb9d47e31b469045ca068e Cr-Commit-Position: refs/heads/master@{#418995}
4 years, 3 months ago (2016-09-15 21:56:54 UTC) #6
msw
4 years, 3 months ago (2016-09-15 23:14:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2341613005/ by msw@chromium.org.

The reason for reverting is: broke sizes with static initializer:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/25612/steps...
# Static initializers in /b/c/b/linux_clobber/src/out/Release/chrome:
# HINT: To get this list, run tools/linux/dump-static-initializers.py
# HINT: diff against the log from the last run to see what changed
# Compiler.cpp std::ios_base::Init::Init()@plt
# Compiler.cpp std::__ioinit [#includes <iostream>, use <ostream> instead]
# Compiler.cpp __cxa_atexit@plt [registers a dtor to run at exit]
# Compiler.cpp __dso_handle
# Compiler.cpp __init_array_end+0x2520.

Powered by Google App Engine
This is Rietveld 408576698