Last files: Change ScopedTempDir::path() to GetPath()

Last files: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
TBR=danakj@chromium.org, petewil@chromium.org, siggi@chromium.org,

Committed: https://crrev.com/6366cd9b50e811aa474c1a3a1910f2d0c1d15c06
Cr-Commit-Position: refs/heads/master@{#418932}

[vabr (Chromium), 2016-09-15 18:55:48]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 18:56:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-09-15 18:57:12]

Description was changed from

==========
Last files: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
==========

to

==========
Last files: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
TBR=danakj@chromium.org, petewil@chromium.org, siggi@chromium.org,
==========

[vabr (Chromium), 2016-09-15 18:57:12]

vabr@chromium.org changed reviewers:
+ danakj@chromium.org, petewil@chromium.org, siggi@chromium.org

[vabr (Chromium), 2016-09-15 18:59:26]

Hello reviewers,

This CL is purely a mechanical change (renaming path->GetPath + formatting). In
accordance with the second point in
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...,
I will TBR it to you all. The "appropriate level of review or general approval"
is supplied here by the review of https://codereview.chromium.org/2275553005/
and the e-mail thread
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/_l2SCF21T1U/7dqsq....

TBR-ed OWNERS:


danakj@chromium.org for base/win/shortcut_unittest.cc
petewil@chromium.org for
components/offline_pages/offline_page_metadata_store_impl_unittest.cc
siggi@chromium.org for
components/browser_watcher/postmortem_minidump_writer_win_unittest.cc

Thanks!
Vaclav

[vabr (Chromium), 2016-09-15 18:59:35]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2016-09-15 18:59:38]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:59:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-15 19:00:15]

LGTM

[commit-bot: I haz the power, 2016-09-15 19:37:50]

Description was changed from

==========
Last files: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
TBR=danakj@chromium.org, petewil@chromium.org, siggi@chromium.org,
==========

to

==========
Last files: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
TBR=danakj@chromium.org, petewil@chromium.org, siggi@chromium.org,
==========

[commit-bot: I haz the power, 2016-09-15 19:37:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 19:40:09]

Description was changed from

==========
Last files: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
TBR=danakj@chromium.org, petewil@chromium.org, siggi@chromium.org,
==========

to

==========
Last files: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
TBR=danakj@chromium.org, petewil@chromium.org, siggi@chromium.org,

Committed: https://crrev.com/6366cd9b50e811aa474c1a3a1910f2d0c1d15c06
Cr-Commit-Position: refs/heads/master@{#418932}
==========

[commit-bot: I haz the power, 2016-09-15 19:40:11]

Patchset 1 (id:??) landed as
https://crrev.com/6366cd9b50e811aa474c1a3a1910f2d0c1d15c06
Cr-Commit-Position: refs/heads/master@{#418932}

[Pete Williamson, 2016-09-15 23:02:57]

LGTM for offline_page_model_metadata_store_impl_unittest.cc