third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py - Issue 2347643002: Refactor the way that SCM changes are tracked and aggregated in rebaseline.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py

Issue 2347643002: Refactor the way that SCM changes are tracked and aggregated in rebaseline.py. (Closed)

Patch Set: Refactor the way that SCM changes are tracked and aggregated. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py

index f50c778e94e0400d7ae77cc59846057981842cf4..cfb08b2df1a03bed9d395405a5c198dfa2b8b63c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py

@@ -51,7 +51,7 @@ class OptimizeBaselines(AbstractRebaseliningCommand):

for test_name in tests:

files_to_delete, files_to_add = self._optimize_baseline(optimizer, test_name)

for path in files_to_delete:

- self._delete_from_scm_later(path)

+ self._scm_changes.delete_file(path)

for path in files_to_add:

- self._add_to_scm_later(path)

+ self._scm_changes.add_file(path)

self._print_scm_changes()