[parser] Fix unfinalized block scope in non-lexical for each

[parser] Fix unfinalized block scope in non-lexical for each

In release mode, statements like:

    var i;
    for (i of [0]) { let j; debugger; }

would end up with one more block scope than in the debug modes.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/be20666469d2bd28c2b40a4c6cb5085aee420fea
Cr-Commit-Position: refs/heads/master@{#39465}

[nickie, 2016-09-15 14:49:20]

Description was changed from

==========
[parser] Fix unfinalized block scope in non-lexical for each

In release mode, statements like:

    var i;
    for (i of [0]) { let j; debugger; }

would end up with one more block scope than in the debug modes.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Fix unfinalized block scope in non-lexical for each

In release mode, statements like:

    var i;
    for (i of [0]) { let j; debugger; }

would end up with one more block scope than in the debug modes.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

[nickie, 2016-09-15 14:50:04]

This was a tricky one.  Without this patch, the last of the added tests would
pass in the debug modes but would fail in release mode.

[nickie, 2016-09-15 14:50:10]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 14:50:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nickie, 2016-09-15 14:54:25]

https://codereview.chromium.org/2347633002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (left):

https://codereview.chromium.org/2347633002/diff/1/src/parsing/parser.cc#oldco...
src/parsing/parser.cc:2670: DCHECK_NULL(for_state.FinalizedBlockScope());
Method FinalizedBlockScope() has side effects, especially in the case that its
result is NULL.

[commit-bot: I haz the power, 2016-09-15 15:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 15:35:46]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-09-15 15:54:45]

lgtm

Nice catch, this is a problem I run into ~once a year, where something moves
into a DCHECK and things start to just subtly change in release mode.

[marja, 2016-09-16 08:24:54]

lgtm - nice catch!

[nickie, 2016-09-16 08:37:08]

The CQ bit was checked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-09-16 08:37:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 08:39:43]

Description was changed from

==========
[parser] Fix unfinalized block scope in non-lexical for each

In release mode, statements like:

    var i;
    for (i of [0]) { let j; debugger; }

would end up with one more block scope than in the debug modes.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Fix unfinalized block scope in non-lexical for each

In release mode, statements like:

    var i;
    for (i of [0]) { let j; debugger; }

would end up with one more block scope than in the debug modes.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

[commit-bot: I haz the power, 2016-09-16 08:39:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-16 08:40:11]

Description was changed from

==========
[parser] Fix unfinalized block scope in non-lexical for each

In release mode, statements like:

    var i;
    for (i of [0]) { let j; debugger; }

would end up with one more block scope than in the debug modes.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Fix unfinalized block scope in non-lexical for each

In release mode, statements like:

    var i;
    for (i of [0]) { let j; debugger; }

would end up with one more block scope than in the debug modes.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/be20666469d2bd28c2b40a4c6cb5085aee420fea
Cr-Commit-Position: refs/heads/master@{#39465}
==========

[commit-bot: I haz the power, 2016-09-16 08:40:12]

Patchset 1 (id:??) landed as
https://crrev.com/be20666469d2bd28c2b40a4c6cb5085aee420fea
Cr-Commit-Position: refs/heads/master@{#39465}