Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2347603003: [DevTools] Remove usage of outline-disclosure from resources sidebar. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
caseq, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove usage of outline-disclosure from resources sidebar. This is a step towards removing global outline-disclosure styles and improving components isolation. BUG=none Committed: https://crrev.com/66987714f483625329ed3d83a0413b9a1ad148c9 Cr-Commit-Position: refs/heads/master@{#419087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/resourcesPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
4 years, 3 months ago (2016-09-15 23:05:36 UTC) #2
dgozman
+caseq
4 years, 3 months ago (2016-09-16 00:06:00 UTC) #4
caseq
lgtm
4 years, 3 months ago (2016-09-16 00:24:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347603003/1
4 years, 3 months ago (2016-09-16 00:32:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 03:13:57 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 03:18:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66987714f483625329ed3d83a0413b9a1ad148c9
Cr-Commit-Position: refs/heads/master@{#419087}

Powered by Google App Engine
This is Rietveld 408576698