Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2347593004: test/fix/tweak writePicture/readPicture (Closed)

Created:
4 years, 3 months ago by reed1
Modified:
4 years, 3 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -49 lines) Patch
M src/core/SkPipe.h View 3 chunks +22 lines, -4 lines 0 comments Download
M src/pipe/SkPipeCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pipe/SkPipeCanvas.cpp View 1 chunk +22 lines, -7 lines 0 comments Download
M src/pipe/SkPipeFormat.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pipe/SkPipeReader.cpp View 1 2 chunks +30 lines, -19 lines 0 comments Download
M tests/PipeTest.cpp View 4 chunks +91 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
reed1
4 years, 3 months ago (2016-09-15 20:32:04 UTC) #4
mtklein_C
lgtm https://codereview.chromium.org/2347593004/diff/1/src/pipe/SkPipeReader.cpp File src/pipe/SkPipeReader.cpp (right): https://codereview.chromium.org/2347593004/diff/1/src/pipe/SkPipeReader.cpp#newcode849 src/pipe/SkPipeReader.cpp:849: #if 0 Time to kill?
4 years, 3 months ago (2016-09-15 20:39:41 UTC) #7
reed1
https://codereview.chromium.org/2347593004/diff/1/src/pipe/SkPipeReader.cpp File src/pipe/SkPipeReader.cpp (right): https://codereview.chromium.org/2347593004/diff/1/src/pipe/SkPipeReader.cpp#newcode849 src/pipe/SkPipeReader.cpp:849: #if 0 On 2016/09/15 20:39:41, mtklein_C wrote: > Time ...
4 years, 3 months ago (2016-09-15 21:01:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347593004/20001
4 years, 3 months ago (2016-09-15 21:01:37 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 21:24:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/262052c9261a567f937ae05ade11ea7a3d280f4c

Powered by Google App Engine
This is Rietveld 408576698