MIPS: reland 16744: add context save for GenerateFastApiCall.

MIPS: reland 16744: add context save for GenerateFastApiCall.

Port r16763 (968acfa)

BUG=

[Paul Lind, 2013-09-17 17:54:22]

LGTM, but like to suggest you add an enum for code-readability, for the existing
boolean that lets us emit a return within the LeaveExitFrame macro.

https://codereview.chromium.org/23475052/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):

https://codereview.chromium.org/23475052/diff/1/src/mips/code-stubs-mips.cc#n...
src/mips/code-stubs-mips.cc:2879: __ LeaveExitFrame(save_doubles_, s0, true,
true);
Use new enum EMIT_RETURN.

https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:3954: LeaveExitFrame(false, s0,
!restore_context, true);
Use new enum EMIT_RETURN.

https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips.h
File src/mips/macro-assembler-mips.h (right):

https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.h:852: bool do_return = false);
To make the code more readable, I'd like to see an enum defined for this
do_return flag. Maybe EMIT_RETURN or some other name that would make sense at
the calls-site. Define the enum at the start of this file, something like this:

enum LeaveExitFrameMode {
   EMIT_RETRUN = true;
   NO_EMIT_RETURN = false;
};

Then above is bool do_return = NO_EMIT_RETURN;

[Paul Lind, 2013-09-17 18:35:44]

Patchset 2 LGTM, thanks.

[kilvadyb, 2013-09-17 18:40:42]

https://codereview.chromium.org/23475052/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):

https://codereview.chromium.org/23475052/diff/1/src/mips/code-stubs-mips.cc#n...
src/mips/code-stubs-mips.cc:2879: __ LeaveExitFrame(save_doubles_, s0, true,
true);
On 2013/09/17 17:54:22, Paul Lind wrote:
> Use new enum EMIT_RETURN.

Done.

https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:3954: LeaveExitFrame(false, s0,
!restore_context, true);
On 2013/09/17 17:54:22, Paul Lind wrote:
> Use new enum EMIT_RETURN.

Done.

https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips.h
File src/mips/macro-assembler-mips.h (right):

https://codereview.chromium.org/23475052/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.h:852: bool do_return = false);
On 2013/09/17 17:54:22, Paul Lind wrote:
> To make the code more readable, I'd like to see an enum defined for this
> do_return flag. Maybe EMIT_RETURN or some other name that would make sense at
> the calls-site. Define the enum at the start of this file, something like
this:
> 
> enum LeaveExitFrameMode {
>    EMIT_RETRUN = true;
>    NO_EMIT_RETURN = false;
> };
> 
> Then above is bool do_return = NO_EMIT_RETURN;

Done.

[Paul Lind, 2013-09-17 19:13:38]

Committed as r16778.