chrome/browser/extensions/api/usb/usb_api.cc - Issue 23475048: Fixes crashing in RequestUsbDevicesAccess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/usb/usb_api.cc

Issue 23475048: Fixes crashing in RequestUsbDevicesAccess (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/usb/usb_api.cc

diff --git a/chrome/browser/extensions/api/usb/usb_api.cc b/chrome/browser/extensions/api/usb/usb_api.cc

index 2d3e8d80078631f8ec0b09dfc3b32481d110d79d..0c1637a7ee2213ed778e2f7ef16c83b92fbe8958 100644

--- a/chrome/browser/extensions/api/usb/usb_api.cc

+++ b/chrome/browser/extensions/api/usb/usb_api.cc

@@ -325,6 +325,10 @@ void RequestUsbDevicesAccess(

ScopedDeviceVector devices,

int interface_id,

const base::Callback<void(ScopedDeviceVector result)>& callback) {

+ if (devices->begin() == devices->end()) {

xiyuan 2013/09/14 00:37:31 nit: Can we use devices->empty()? It is more reada

Bei Zhang 2013/09/14 06:05:58 Done.

+ callback.Run(devices.Pass());

+ return;

+ }

(*devices->begin())->RequestUsbAcess(

interface_id,

base::Bind(RequestUsbDevicesAccessHelper, base::Passed(devices.Pass()),

« no previous file with comments | « no previous file | chrome/browser/usb/usb_device.h » ('j') | no next file with comments »