Add transition type qualifier to prerendered pages from omnibox.

Add transition type qualifier to prerendered pages from omnibox.

The transition type of a prerendered page loaded from the omnibox now
has the qualifier PAGE_TRANSITION_FROM_ADDRESS_BAR.

BUG=263246
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243387

[newt (away), 2013-09-12 17:35:28]

PTAL, thank you!

[newt (away), 2013-09-16 21:15:05]

ping

[jochen (gone - plz use gerrit), 2013-09-17 08:37:58]

is it possible to write a test for this?

[jochen (gone - plz use gerrit), 2014-01-03 09:05:41]

Is this CL still needed?

[newt (away), 2014-01-06 14:46:35]

It still makes sense to fix this. I just lost track of this bug, as it's no
longer blocking me.

I'm not familiar with prerendering tests though. Any suggestions for how to
approach testing this?

[jochen (gone - plz use gerrit), 2014-01-07 10:25:13]

I dunno, I had hoped that there is already a test covering this

Adding Timo as he might know

[tburkard, 2014-01-07 10:33:20]

No existing tests for this.

Looks like this would go into prerender_browsertest, could probably be a
little tricky to verify this. If this can be verified in Javascript, it
should be easy to do, analogous to eg prerender_referrer.html. I see here
that chrome.history does have a transition type, including "typed", but I
don't see "from address bar" in there. Is this is not exposed in JS, it
might be a little trickier to test for this.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2014-01-07 10:35:22]

meh

anyway, feel free to land

lgtm

[newt (away), 2014-01-07 17:14:53]

+kmadhusu: to verify that ORIGIN_INSTANT prerendered page loads should also be
tagged with PAGE_TRANSITION_FROM_ADDRESS_BAR

[kmadhusu, 2014-01-07 17:56:25]

On 2014/01/07 17:14:53, newt wrote:
> +kmadhusu: to verify that ORIGIN_INSTANT prerendered page loads should also be
> tagged with PAGE_TRANSITION_FROM_ADDRESS_BAR

lgtm

[commit-bot: I haz the power, 2014-01-07 17:57:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/23475040/76001

[commit-bot: I haz the power, 2014-01-07 21:39:53]

Change committed as 243387