media/audio/audio_manager_base.cc - Issue 23475037: Implement GetAudioOutputDevices for remaining platforms, consolidate tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_manager_base.cc

Issue 23475037: Implement GetAudioOutputDevices for remaining platforms, consolidate tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Merge LKGR, remove anonymous namespaces. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/audio_manager_base.cc

diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc

index 1477ce3c5a44b25add046d34a8792bc385788478..246f8d2a0970594e8ab736677d3136de89234b86 100644

--- a/media/audio/audio_manager_base.cc

+++ b/media/audio/audio_manager_base.cc

@@ -310,8 +310,6 @@ void AudioManagerBase::GetAudioInputDeviceNames(

void AudioManagerBase::GetAudioOutputDeviceNames(

AudioDeviceNames* device_names) {

- // TODO(joi): Remove this and keep pure virtual once implemented everywhere.

- NOTREACHED() << "Don't use this yet, it's not ready on all platforms!";

}

void AudioManagerBase::ReleaseOutputStream(AudioOutputStream* stream) {

« no previous file with comments | « media/audio/audio_input_device_unittest.cc ('k') | media/audio/audio_manager_unittest.cc » ('j') | no next file with comments »