Implement GetAudioOutputDevices for remaining platforms, consolidate tests.

media/audio/win/device_enumeration_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <MMDeviceAPI.h>
 #include <mmsystem.h>
 #include <Functiondiscoverykeys_devpkey.h>  // MMDeviceAPI.h must come first
 
 #include "media/audio/win/audio_manager_win.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/scoped_co_mem.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/scoped_propvariant.h"
 
 using base::win::ScopedComPtr;
 using base::win::ScopedCoMem;
 
 // Taken from Mmddk.h.
 #define DRV_RESERVED                      0x0800
 #define DRV_QUERYFUNCTIONINSTANCEID       (DRV_RESERVED + 17)
 #define DRV_QUERYFUNCTIONINSTANCEIDSIZE   (DRV_RESERVED + 18)
 
 namespace media {
 
-namespace {
-
-bool GetDeviceNamesWinImpl(EDataFlow data_flow,
-                           AudioDeviceNames* device_names) {
+static bool GetDeviceNamesWinImpl(EDataFlow data_flow,
+                                  AudioDeviceNames* device_names) {
   // It is assumed that this method is called from a COM thread, i.e.,
   // CoInitializeEx() is not called here again to avoid STA/MTA conflicts.
   ScopedComPtr<IMMDeviceEnumerator> enumerator;
   HRESULT hr = enumerator.CreateInstance(__uuidof(MMDeviceEnumerator), NULL,
                                          CLSCTX_INPROC_SERVER);
   DCHECK_NE(CO_E_NOTINITIALIZED, hr);
   if (FAILED(hr)) {
     LOG(WARNING) << "Failed to create IMMDeviceEnumerator: " << std::hex << hr;
     return false;
   }
@@ skipping 54 matching lines @@
 }
 
 // The waveform API is weird in that it has completely separate but
 // almost identical functions and structs for input devices vs. output
 // devices. We deal with this by implementing the logic as a templated
 // function that takes the functions and struct type to use as
 // template parameters.
 template <UINT (__stdcall *NumDevsFunc)(),
           typename CAPSSTRUCT,
           MMRESULT (__stdcall *DevCapsFunc)(UINT_PTR, CAPSSTRUCT*, UINT)>
-bool GetDeviceNamesWinXPImpl(AudioDeviceNames* device_names) {
+static bool GetDeviceNamesWinXPImpl(AudioDeviceNames* device_names) {
   // Retrieve the number of active waveform input devices.
   UINT number_of_active_devices = NumDevsFunc();
   if (number_of_active_devices == 0)
     return true;
 
   AudioDeviceName device;
   CAPSSTRUCT capabilities;
   MMRESULT err = MMSYSERR_NOERROR;
 
   // Loop over all active capture devices and add friendly name and
@@ skipping 14 matching lines @@
     // Store the "unique" name (we use same as friendly name on Windows XP).
     device.unique_id = device.device_name;
 
     // Add combination of user-friendly and unique name to the output list.
     device_names->push_back(device);
   }
 
   return true;
 }
 
-}  // namespace
-
 bool GetInputDeviceNamesWin(AudioDeviceNames* device_names) {
   return GetDeviceNamesWinImpl(eCapture, device_names);
 }
 
 bool GetOutputDeviceNamesWin(AudioDeviceNames* device_names) {
   return GetDeviceNamesWinImpl(eRender, device_names);
 }
 
 bool GetInputDeviceNamesWinXP(AudioDeviceNames* device_names) {
   return GetDeviceNamesWinXPImpl<
@@ skipping 46 matching lines @@
 
     result = waveInGetDevCaps(i, &capabilities, sizeof(capabilities));
     if (result == MMSYSERR_NOERROR)
       return WideToUTF8(capabilities.szPname);
   }
 
   return std::string();
 }
 
 }  // namespace media