Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2347503002: Fix for chrome://cast getting blocked by content security policy. (Closed)

Created:
4 years, 3 months ago by paulmeyer
Modified:
4 years, 3 months ago
Reviewers:
sheretov
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for chrome://cast getting blocked by content security policy. The provided policy for the cast UI was "object-src *", which used to include "chrome:" until a recent CL changed the use of “*” from a blacklist (that did not include "chrome:") to a whitelist (that still does not include "chrome:"). Because of this, the policy just needs to be updated to specifically allow "chrome:" now. BUG=634168 Committed: https://crrev.com/67b0b5d046af90992bc94390a90647d7b4a00353 Cr-Commit-Position: refs/heads/master@{#418883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/cast/cast_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
paulmeyer
4 years, 3 months ago (2016-09-15 01:00:54 UTC) #2
sheretov
lgtm
4 years, 3 months ago (2016-09-15 05:09:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347503002/1
4 years, 3 months ago (2016-09-15 12:16:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/293738)
4 years, 3 months ago (2016-09-15 13:38:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347503002/1
4 years, 3 months ago (2016-09-15 15:11:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 16:22:21 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:10:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67b0b5d046af90992bc94390a90647d7b4a00353
Cr-Commit-Position: refs/heads/master@{#418883}

Powered by Google App Engine
This is Rietveld 408576698