Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 23475023: Revert 157198 "Possible fix for a Mac performance regression." (Closed)

Created:
7 years, 3 months ago by Chris Evans
Modified:
7 years, 3 months ago
Reviewers:
Chris Evans
CC:
blink-reviews
Visibility:
Public.

Description

Revert 157198 "Possible fix for a Mac performance regression." > Possible fix for a Mac performance regression. > > Introduced in > http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Vector.h?revision=157005 > > We now do the minimal amount of work possible on Vector destruction. We should > now be faster than ever before: > - The most common case is actually a totally unused Vector with no inline > storage. In this case, we can bail and do no other work, if the buffer pointer > is NULL. > - There's no need to set m_size to 0 in the destructor; we've already checked > that it is 0 and if not called resize(0) which will set it to 0. > - In the Vector with inline storage case, we once again check m_size before > calling shrink(), which might not be inline. It is common for m_size to be 0. > > This also saves >50KB on a GCC Release build. clang, as usual, is barely > affected on account of its less aggressive inlining. > > > BUG=283760 > > Review URL: https://chromiumcodereview.appspot.com/23455034 TBR=cevans@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -37 lines) Patch
M trunk/Source/wtf/Deque.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/wtf/Vector.h View 8 chunks +18 lines, -36 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
7 years, 3 months ago (2013-09-05 02:56:02 UTC) #1
Chris Evans
7 years, 3 months ago (2013-09-05 02:56:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r157266.

Powered by Google App Engine
This is Rietveld 408576698